[core] Set default regression port #1786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliviertassinari
force-pushed
the
test-regression-hard-code-default-port
branch
from
b11472c to
539552b
Compare
oliviertassinari
force-pushed
the
test-regression-hard-code-default-port
branch
from
dc6eea6 to
bc5f869
Compare
mj12albert
approved these changes
Apr 28, 2025
michaldudak
added
scope: code-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to understand why the visual regression tests work correctly in Base UI but are broken in MUI X. Turns out, we didn't correctly copy Base UI in MUI X mui/mui-x#17564. But also, turns out, that Base UI rely on the default port of Vite to not change (https://www.reddit.com/r/programming/comments/xh1vyr/fun_fact_vites_default_port_is_5173_which_spells/) for this to work. Since we might want to scope the port per project, not be dependent on the default port, and help debug, it seems best to explicitly specify the value.