Skip to content

[api-major] Remove the SVG back-end (PR 15173 follow-up) #16699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[api-major] Remove the SVG back-end (PR 15173 follow-up) #16699

merged 1 commit into from
Oct 3, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jul 16, 2023 •
edited
Loading

This has been deprecated since version 2.15.349, which is a year ago.
Removing this will also simplify some upcoming changes, specifically outputting of JavaScript modules in the builds.

@Snuffleupagus Snuffleupagus force-pushed the rm-svg branch 6 times, most recently from b2c40d0 to 60c3850 Compare July 22, 2023 07:42
@Snuffleupagus Snuffleupagus mentioned this pull request Jul 26, 2023
Closed
@Snuffleupagus Snuffleupagus force-pushed the rm-svg branch 2 times, most recently from 7506288 to 3220163 Compare July 30, 2023 13:43
@tamuratak tamuratak mentioned this pull request Aug 8, 2023
Closed
@Snuffleupagus Snuffleupagus force-pushed the rm-svg branch 2 times, most recently from 67ed570 to f9f9476 Compare August 13, 2023 12:57
@Snuffleupagus Snuffleupagus force-pushed the rm-svg branch 2 times, most recently from cfb2d80 to c40a04b Compare September 1, 2023 10:06
@Snuffleupagus Snuffleupagus force-pushed the rm-svg branch 2 times, most recently from 4fa0501 to a2482a8 Compare October 1, 2023 21:11
@Snuffleupagus
[api-major] Remove the SVG back-end (PR 15173 follow-up)
3ced0de 
This has been deprecated since version `2.15.349`, which is a year ago.
Removing this will also simplify some upcoming changes, specifically outputting of JavaScript modules in the builds.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/19d156ca67fcfde/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/19d156ca67fcfde/output.txt

Total script time: 1.44 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9387409e81d7c16/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dc12ab9a9e8ef22/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dc12ab9a9e8ef22/output.txt

Total script time: 27.69 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 20

Image differences available at: http://54.241.84.105:8877/dc12ab9a9e8ef22/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9387409e81d7c16/output.txt

Total script time: 38.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 22

Image differences available at: http://54.193.163.58:8877/9387409e81d7c16/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus marked this pull request as ready for review October 1, 2023 22:35
calixteman
calixteman approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus removed the request for review from timvandermeij October 3, 2023 13:13
@Snuffleupagus Snuffleupagus merged commit 426209c into mozilla:master Oct 3, 2023
@Snuffleupagus Snuffleupagus deleted the rm-svg branch October 3, 2023 13:13
lublak added a commit to lublak/pdfdataextract that referenced this pull request Mar 19, 2024
@lublak
fix all upgrade issues, remove svg support
c5aeb7f 
Whether I will add svg again will be seen in the future. Then you would have to implement your own implementation in any case, as the support from pdfjs has been cancelled. mozilla/pdf.js#16699
@Akxe Akxe mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman