Replace XMLHttpRequest usage with the Fetch API in Driver._send
#14642
Conversation
This is another part in a series of patches that try to re-implement PR 14287 in smaller steps. Besides converting `Driver._send` to use the Fetch API, this also changes the method to return a `Promise` to get rid of the callback function. Please note that I *purposely* try to maintain the existing behaviour of re-sending the data on failure/unexpected response, including how/where the old callback function was invoked.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/59cf75fa78a8adf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cd8ae3506e1d812/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cd8ae3506e1d812/output.txt Total script time: 20.61 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/59cf75fa78a8adf/output.txt Total script time: 21.05 mins
Image differences available at: http://54.241.84.105:8877/59cf75fa78a8adf/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5245d2ecb25cb49/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aa28ee2885a0c68/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5245d2ecb25cb49/output.txt Total script time: 24.70 mins
Image differences available at: http://54.241.84.105:8877/5245d2ecb25cb49/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/aa28ee2885a0c68/output.txt Total script time: 26.05 mins
|
|
Looks much better this way; thanks! |
This is another part in a series of patches that try to re-implement PR #14287 in smaller steps.
Besides converting
Driver._sendto use the Fetch API, this also changes the method to return aPromiseto get rid of the callback function.Please note that I purposely try to maintain the existing behaviour of re-sending the data on failure/unexpected response, including how/where the old callback function was invoked.