-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Convert the test-suite to use the Fetch API rather than XMLHttpRequest #14287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff40810
to
6b3eefc
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/543fcfd64ac6d04/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/abced55db150cf5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/abced55db150cf5/output.txt Total script time: 22.45 mins
Image differences available at: http://54.241.84.105:8877/abced55db150cf5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/543fcfd64ac6d04/output.txt Total script time: 43.29 mins
Image differences available at: http://54.193.163.58:8877/543fcfd64ac6d04/reftest-analyzer.html#web=eq.log |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7732239a02b2e48/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/38cf12f042f9f81/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7732239a02b2e48/output.txt Total script time: 2.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/38cf12f042f9f81/output.txt Total script time: 6.00 mins
|
6b3eefc
to
a7f9311
Compare
The Fetch API should be well supported across modern browsers, see https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API#browser_compatibility, and allows simplifying the code thanks to all of its method returning Promises. This patch also introduces template strings, rather than using manual string concatenation, in a few spots in `test/driver.js`.
…mise This allows (some) simplification of the call-sites, since we can now use `async`/`await` directly rather than having to manually wrap a lot of code in a Promise.
a7f9311
to
6b7e527
Compare
Why'd you close this? |
Because I was getting additional intermittents locally with the latest version of the patch (e.g. in |
Convert the test-suite to use the Fetch API rather than XMLHttpRequest
The Fetch API should be well supported across modern browsers, see https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API#browser_compatibility, and allows simplifying the code thanks to all of its method returning Promises.
This patch also introduces template strings, rather than using manual string concatenation, in a few spots in
test/driver.js
.Finally, intest/driver.js
, we'll now use the PDF.js utility functioncreateObjectURL
to get rid of theFileReader
usage.Convert the
writeSVG
function, intest/driver.js
, to return a PromiseThis allows (some) simplification of the call-sites, since we can now use
async
/await
directly rather than having to manually wrap a lot of code in a Promise.