[api-minor] Stop exposing the createObjectURL helper function in the API
#14551
Conversation
…her than the `createObjectURL` helper function Given that most of the code-base is already using native functionality, we can update these unit-tests similarily as well. - For the `blob:`-URL test, we simply use `URL.createObjectURL(...)` and `Blob` directly instead. - For the `data:`-URL test, we simply use `btoa` to do the Base64 encoding and then build the final URL-string.
…e API With recent changes, specifically PR 14515 *and* the previous patch, the `createObjectURL` helper function is now only used with the SVG back-end. All other call-sites, throughout the code-base, are now using `URL.createObjectURL(...)` directly and it no longer seems necessary to keep exposing the helper function in the API. Finally, the `createObjectURL` helper function is moved into the `src/display/svg.js` file to avoid unnecessarily duplicating this code on both the main- and worker-threads.
Snuffleupagus
force-pushed
the
mv-createObjectURL
branch
from
391651f to
b87a243
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/18156cc1ae166ba/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bfe7e3af341422f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/18156cc1ae166ba/output.txt Total script time: 24.06 mins
Image differences available at: http://54.241.84.105:8877/18156cc1ae166ba/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bfe7e3af341422f/output.txt Total script time: 25.47 mins
Image differences available at: http://54.193.163.58:8877/bfe7e3af341422f/reftest-analyzer.html#web=eq.log |
|
I don't really understand these Windows-only regressions, since testing in e.g. PR #14547 didn't fail. |
|
Looks good; thank you for improving this! |
Update two
display_utilsunit-tests to use native functionality rather than thecreateObjectURLhelper functionGiven that most of the code-base is already using native functionality, we can update these unit-tests similarily as well.
blob:-URL test, we simply useURL.createObjectURL(...)andBlobdirectly instead.data:-URL test, we simply usebtoato do the Base64 encoding and then build the final URL-string.[api-minor] Stop exposing the
createObjectURLhelper function in the APIWith recent changes, specifically PR [api-minor] Remove support for browsers/environments without fully working
URL.createObjectURLimplementations #14515 and the previous patch, thecreateObjectURLhelper function is now only used with the SVG back-end.All other call-sites, throughout the code-base, are now using
URL.createObjectURL(...)directly and it no longer seems necessary to keep exposing the helper function in the API.Finally, the
createObjectURLhelper function is moved into thesrc/display/svg.jsfile to avoid unnecessarily duplicating this code on both the main- and worker-threads.