Update the file used with the xfa_bug1720182 test-case
#14547
Conversation
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/03af9f8c84d9421/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2e6ac3dd2c1bc56/output.txt |
The file used in this test-case is *identical* to, i.e. the md5 entry perfectly matches, the file used with the `xfa_bug1716380` test-case. While it's obviously fine to use the same PDF document in different reference-tests, note how we e.g. have both `eq` and `text` tests for one document, we should always avoid adding *duplicate* files in the `test/pdfs/` folder.
Snuffleupagus
force-pushed
the
xfa_bug1720182-file
branch
from
1f2042f to
60efae9
Compare
Snuffleupagus
changed the title
xfa_bug172018 test-casexfa_bug1720182 test-case
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/03af9f8c84d9421/output.txt Total script time: 10.12 mins
Image differences available at: http://54.241.84.105:8877/03af9f8c84d9421/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2e6ac3dd2c1bc56/output.txt Total script time: 12.22 mins
Image differences available at: http://54.193.163.58:8877/2e6ac3dd2c1bc56/reftest-analyzer.html#web=eq.log |
|
Maybe we should have some kind of linting to avoid this kind of problems. |
Well, I didn't exactly find this manually :-) |
While it's obviously fine to use the same PDF document in different reference-tests, note how we e.g. have both `eq` and `text` tests for one document, we should always avoid adding *duplicate* files in the `test/pdfs/` folder.
Snuffleupagus
force-pushed
the
xfa_bug1720182-file
branch
from
23e463d to
188752e
Compare
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4e7aae2e3e65ed9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f4732137930646e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f4732137930646e/output.txt Total script time: 19.41 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4e7aae2e3e65ed9/output.txt Total script time: 20.02 mins
Image differences available at: http://54.241.84.105:8877/4e7aae2e3e65ed9/reftest-analyzer.html#web=eq.log |
|
Nice find! |
The file used in this test-case is identical to, i.e. the md5 entry perfectly matches, the file used with the
xfa_bug1716380test-case.While it's obviously fine to use the same PDF document in different reference-tests, note how we e.g. have both
eqandtexttests for one document, we should always avoid adding duplicate files in thetest/pdfs/folder.