Support cmaps with only CID characters, when building the ToUnicode-map (issue 9367) #14041
Conversation
…ap (issue 9367) In this particular case the `CMap`-data that we create contains only numbers, but no strings, which causes `PartialEvaluator.readToUnicode` to create a ToUnicode-map with only empty strings. *Please note:* This is yet another case where I don't know if it's necessarily the best and most correct solution, but it does fix the referenced issue.
Snuffleupagus
force-pushed
the
issue-9367
branch
from
a4f52e1 to
ed73cf6
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4ca4cd3757d15af/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/09a9b245fa4ca65/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4ca4cd3757d15af/output.txt Total script time: 20.16 mins
Image differences available at: http://54.241.84.105:8877/4ca4cd3757d15af/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/93f3c215614c452/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/09a9b245fa4ca65/output.txt Total script time: 40.03 mins
Image differences available at: http://54.193.163.58:8877/09a9b245fa4ca65/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/93f3c215614c452/output.txt Total script time: 19.01 mins
Image differences available at: http://54.241.84.105:8877/93f3c215614c452/reftest-analyzer.html#web=eq.log |
…ndard fonts, into a helper function This reduces some unnecessary duplication, since we currently have essentially the same code in a handful of places in the `Font.fallbackToSystemFont`-method.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a1ab01b187cae96/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a5fef835af00ee2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a1ab01b187cae96/output.txt Total script time: 17.42 mins
Image differences available at: http://54.241.84.105:8877/a1ab01b187cae96/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a5fef835af00ee2/output.txt Total script time: 35.86 mins
Image differences available at: http://54.193.163.58:8877/a5fef835af00ee2/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f5e3d11d7bdba75/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f5e3d11d7bdba75/output.txt Total script time: 4.13 mins Published |
|
Looks good to me; thank you! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f58fedf6f3d7721/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/d11cdbe684e7afe/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f58fedf6f3d7721/output.txt Total script time: 17.94 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d11cdbe684e7afe/output.txt Total script time: 37.01 mins
|
In this particular case the
CMap-data that we create contains only numbers, but no strings, which causesPartialEvaluator.readToUnicodeto create a ToUnicode-map with only empty strings.Please note: This is yet another case where I don't know if it's necessarily the best and most correct solution, but it does fix the referenced issue.
Fixes #9367