Skip to content

[Bugfix] Fix character encoding issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

NoftScarlet
Copy link

@NoftScarlet NoftScarlet commented Jan 19, 2022

Description

Trello
To fix this issue, I updated the code based on what was change in this PR for fixing the same issue.

To verify

https://ychen-hosted-envs.web.app/pdfjs-encoding/

Steps the above demo was created (and I hope they are correct):

  1. Copy the changed files from this repo into webviewer repo src/pdfjs/src/src & replace the files there
  2. npm run build-pdfjs-workers
  3. npm run build-pdfjs
  4. npm run host-env-build

API change discussion link

No changes to API

UI/UX change discussion link

No changes to UIUX

Effect on pdf.js express

This fixes a pdfjs specific issue

Checklist

  • Added jsdoc comments for newly exposed APIs
  • Added @method in the jsdoc comments for newly exposed functions, e.g. @method Core.AnnotationManager#exportAnnotations
  • Double checked spelling and grammar in jsdoc comments
  • Used square brackets around property names where it is necessary (Object properties from user provided parameters, properties that are defined with quotes in Object.defineProperties)
  • When using innerHTML or dangerouslySetInnerHTML double checked they are actually needed and if they are needed, that user data is sanitized
  • Tests are not available to pdfjs express
  • If PR contains any UI, visual updates, generate a link (npm run host-env) and send it over Xodo to Carolyn Chen (@caroly) or Joshua Sun (@JoshuaSun) for review.

Related issues

pdfjs express community topic link

@NoftScarlet NoftScarlet marked this pull request as ready for review January 19, 2022 21:01
@lbittner-pdftron lbittner-pdftron merged commit 6d90343 into master Jan 21, 2022
@lbittner-pdftron lbittner-pdftron deleted the bugfix/font-encoding branch January 21, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants