Enable linting in the test/resources/ folder, and fix the "Remote property injection" warning (issue 13862)
#13869
Conversation
Also, update the `.stylelintignore` file to agree with the `.eslintignore` file since the configurations had (unintentionally) diverged.
These changes were done automatically, by using the `gulp lint --fix` command.
…-analyzer.js` Given that issue 13862 tracks updating/modernizing the code, this patch purposely limits the scope of the changes. In particular, the following things are still left to address: - The ESLint `no-undef` errors; for now the rule is simply disabled globally in this file. - A couple of unused variables are commented out for now, but could perhaps just be removed.
… Object (issue 13862) This patch (basically) mirrors the implementation in PR 13831, to get rid of the "Remote property injection" warning.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/47d0a0ed1e4c2f6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/3dd40d383354705/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/47d0a0ed1e4c2f6/output.txt Total script time: 29.50 mins
Image differences available at: http://54.67.70.0:8877/47d0a0ed1e4c2f6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/3dd40d383354705/output.txt Total script time: 35.60 mins
Image differences available at: http://3.101.106.178:8877/3dd40d383354705/reftest-analyzer.html#web=eq.log |
|
Thanks a lot for doing this; it already modernizes the code quite a bit and gets rid of most CodeQL warnings/errors! |
Please refer to the individual commit messages for additional details.
I'm not going to fix the main part of issue #13862, which is about updating and modernizing the overall implementation, however these patches will hopefully help with that work by enabling linting of the code.