Skip to content

Improve the reftest analyzer code #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timvandermeij opened this issue Aug 3, 2021 · 2 comments
Open

Improve the reftest analyzer code #13862

timvandermeij opened this issue Aug 3, 2021 · 2 comments
Labels

Comments

@timvandermeij
Copy link
Contributor

For the reftest analyzer I think the easiest solution would be to take over parts from the upstream one at https://github.com/mozilla/gecko-dev/blob/master/layout/tools/reftest/reftest-analyzer.xhtml since that one already got refactored to get rid of window usage. We shouldn't take over everything since there is also a large block of testing code in there, and we have made our own modifications to our version in https://github.com/mozilla/pdf.js/commits/master/test/resources/reftest-analyzer.js (both functional and code-wise, for example to not use XHTML and put the JS in a separate file), but it might save some time fixing this.

(Subtask of #13829)

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Aug 3, 2021

Also, if we're going to be updating/modernizing that code we should probably start with enabling ESLint/Stylelint/Prettier for that folder since otherwise it's just too easy to introduce (avoidable) bugs during the re-factoring.

@timvandermeij
Copy link
Contributor Author

The security warnings are fixed by the PRs above. This issue is mainly about cherry-picking improvements from upstream and removing dead code.

@timvandermeij timvandermeij changed the title Fix the security warnings related to the reftest analyzer Improve the reftest analyzer code Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants