-
Notifications
You must be signed in to change notification settings - Fork 612
Add stomp
target link to moveit_planners_stomp
tests
#3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running I am testing that this resolves the Space ROS build issue and request a backport to jazzy if approved. |
Perfect, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3437 +/- ##
==========================================
- Coverage 45.87% 45.07% -0.79%
==========================================
Files 717 717
Lines 62636 62639 +3
Branches 7581 7586 +5
==========================================
- Hits 28728 28230 -498
- Misses 33742 34240 +498
- Partials 166 169 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Confirmed this fixes the issue with the Space ROS build space-ros/docker#224 |
Thanks for the quick-turnaround! Can we expect this change to be back ported to the jazzy branch or do we need to retarget our build to accommodate? |
(cherry picked from commit ec5b368)
(cherry picked from commit ec5b368) Co-authored-by: Bckempa <[email protected]>
Description
Fix missing linkage in
moveit_planners_stomp
tests viatarget_link_libraries
declaration as suggested in #3436 (comment)Fixes #3436
Checklist