INTMDB-364 Add support for serverless private endpoints (AWS + Azure) #913

martinstibbe · 2022-11-09T19:33:36Z

Description

Add support for serverless private endpoints (AWS)

Link to any related issue(s):

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the Terraform contribution guidelines
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code

Further comments

Zuhairahmed

Few comments below, also can you add documentation as part of this PR? i think we will need 5
Resource:
mongodbatlas_privatelink_endpoint_severless
mongodbatlas_privatelink_endpoint_service_severless

Data Source:
mongodbatlas_privatelink_endpoint_severless
mongodbatlas_privatelink_endpoint_service_severless
mongodbatlas_privatelink_endpoints_service_severless

mongodbatlas/data_source_mongodbatlas_privatelink_endpoint_service_serverless.go

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_serverless.go

…vider-mongodbatlas into INTMDB-364

Zuhairahmed

Few doc comments below

website/docs/r/privatelink_endpoint_serverless.html.markdown

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

website/docs/r/privatelink_endpoint_serverless.html.markdown

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

andreaangiolillo

Code LGTM

Zuhairahmed · 2022-11-10T15:15:34Z

Few comments below, also can you add documentation as part of this PR? i think we will need 5 Resource: mongodbatlas_privatelink_endpoint_severless mongodbatlas_privatelink_endpoint_service_severless

Data Source: mongodbatlas_privatelink_endpoint_severless mongodbatlas_privatelink_endpoint_service_severless mongodbatlas_privatelink_endpoints_service_severless

Thanks @martinstibbe for these updates! Just following up on above. We have 1 data source file as part if this PR "endpoint_service_serverless", can you double check if we need 2 more: "endpoints_service_serverless" and "endpoint_serverless"?

…tion

themantissa

Discussed this with @Zuhairahmed and it seems the original ticket I created was limited to just AWS while I was out. This need to include Azure as well. Please add the Azure parameters (which it looks like @martinstibbe already added to the go client), at least minimal Azure tests, Azure examples (both MDB and Azure side) and note Azure is supported.

Other comments are mostly docs - note that there was a commit while I was reviewing so I believe all my comments still apply but keep that in mind.

themantissa · 2022-11-10T20:28:54Z

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

+	provider_name = "AWS"
+}
+
+


Comment from the resource docs below - we copy the resource block into the data source
As noted in the tutorial: https://www.mongodb.com/docs/atlas/security-serverless-private-endpoint/ there is a step between "mongodbatlas_privatelink_endpoint_serverless" and resource "mongodbatlas_privatelink_endpoint_service_serverless" which is to create the interface endpoint on the AWS side. We provide how to do this in the regular privatelink docs: the https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/privatelink_endpoint_service Let's do the same here.

themantissa · 2022-11-10T20:31:39Z

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

+* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service. MongoDB Cloud returns null while it creates the endpoint service.
+* `status` - Human-readable label that indicates the current operating status of the private endpoint. Values include: RESERVATION_REQUESTED, RESERVED, INITIATING, AVAILABLE, FAILED, DELETING.
+
+For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/createOnePrivateEndpointForOneServerlessInstance/)  and [MongoDB Atlas API - Online Archive](https://docs.atlas.mongodb.com/reference/api/online-archive/) Documentation.


Why would we refer to Online Archive here? Also I think you mixed up resource and data source pages :)

Suggested change

For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/createOnePrivateEndpointForOneServerlessInstance/) and [MongoDB Atlas API - Online Archive](https://docs.atlas.mongodb.com/reference/api/online-archive/) Documentation.

For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api/serverless-private-endpoints-get-one/).

themantissa · 2022-11-10T20:32:42Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+
+In addition to all arguments above, the following attributes are exported:
+* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.
+* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service. MongoDB Cloud returns null while it creates the endpoint service.


Do we really need to mention the null return here? Will the Terraform user ever see that?

Suggested change

* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service. MongoDB Cloud returns null while it creates the endpoint service.

* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service.

that's the definition we have in new docs: https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/createOnePrivateEndpointForOneServerlessInstance

agree doesn't make sense for external user using terraform, we should delete second sentence

themantissa · 2022-11-10T20:35:06Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+	provider_name = "AWS"
+}
+
+


As noted in the tutorial: https://www.mongodb.com/docs/atlas/security-serverless-private-endpoint/ there is a step between "mongodbatlas_privatelink_endpoint_serverless" and resource "mongodbatlas_privatelink_endpoint_service_serverless" which is to create the interface endpoint on the AWS side. We provide how to do this in the regular privatelink docs: the https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/privatelink_endpoint_service Let's do the same here.

This is still missing the AWS block. Azure has one so just need this like that.

themantissa · 2022-11-10T20:35:56Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+
+resource "mongodbatlas_privatelink_endpoint_service_serverless" "test" {
+	project_id   = "<PROJECT_ID>"
+	instance_name = "test-db"


I don't think they'd want to hard code this but use mongodbatlas_serverless_instance.test.name again?

themantissa · 2022-11-10T20:50:45Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+* `comment` - Human-readable string to associate with this private endpoint.
+* `status` - Human-readable label that indicates the current operating status of the private endpoint. Values include: RESERVATION_REQUESTED, RESERVED, INITIATING, AVAILABLE, FAILED, DELETING.
+
+For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api/serverless-private-endpoints-get-one/)  and [MongoDB Atlas API - Online Archive](https://docs.atlas.mongodb.com/reference/api/online-archive/) Documentation.


Suggested change

For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api/serverless-private-endpoints-get-one/) and [MongoDB Atlas API - Online Archive](https://docs.atlas.mongodb.com/reference/api/online-archive/) Documentation.

For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/createOnePrivateEndpointForOneServerlessInstance/).

themantissa · 2022-11-10T20:58:34Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+## Argument Reference
+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required) Human-readable label that identifies the serverless instance associated with the tenant endpoint


Suggested change

* `instance_name` - (Required) Human-readable label that identifies the serverless instance associated with the tenant endpoint

* `instance_name` - (Required) Human-readable label that identifies the serverless instance

themantissa · 2022-11-10T20:58:47Z

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

+## Argument Reference
+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required) Serverless instance name to attach private


Suggested change

* `instance_name` - (Required) Serverless instance name to attach private

* `instance_name` - (Required) Human-readable label that identifies the serverless instance

themantissa · 2022-11-10T20:59:50Z

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

+## Argument Reference
+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required) Serverless instance name to attach private


Suggested change

* `instance_name` - (Required) Serverless instance name to attach private

* `instance_name` - (Required) Human-readable label that identifies the serverless instance

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

…loud_provider_endpoint_id

Zuhairahmed

Few comments below, thanks for all the updates thus far!

Zuhairahmed · 2022-11-13T21:54:00Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+---
+
+
+# Data Source: privatelink_endpoint_service_serverless


Suggested change

# Data Source: privatelink_endpoint_service_serverless

# Resource: privatelink_endpoint_service_serverless

Zuhairahmed · 2022-11-13T21:54:16Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+---
+
+
+# Data Source: privatelink_endpoint_serverless


Suggested change

# Data Source: privatelink_endpoint_serverless

# Resource: privatelink_endpoint_serverless

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

Zuhairahmed · 2022-11-13T22:01:10Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required)Human-readable label that identifies the serverless instance.
+* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.


Suggested change

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

Zuhairahmed · 2022-11-13T22:12:58Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+## Argument Reference
+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required)Human-readable label that identifies the serverless instance.


Suggested change

* `instance_name` - (Required)Human-readable label that identifies the serverless instance.

* `instance_name` - (Required) Human-readable label that identifies the serverless instance.

website/docs/r/privatelink_endpoint_serverless.html.markdown

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

Zuhairahmed · 2022-11-13T22:20:41Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+## Attributes Reference
+
+In addition to all arguments above, the following attributes are exported:
+* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.


Suggested change

* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

Zuhairahmed

Thanks for quick turnaround @martinstibbe. Few more minor doc edits, otherwise LTGM!

Zuhairahmed · 2022-11-14T01:37:46Z

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required) Human-readable label that identifies the serverless instance 
+* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.


Suggested change

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

Zuhairahmed · 2022-11-14T01:39:19Z

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

+Each object in the `results` array represents an online archive with the following attributes:
+* `cloud_provider_endpoint_id` - Unique string that identifies the private endpoint's network interface.
+* `comment` - Human-readable string to associate with this private endpoint.
+* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.


Suggested change

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [|aws| PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

andreaangiolillo

LGTM

themantissa

Code looks good - docs still need some work, including comments made in last review that are not yet addressed. Thanks!

website/docs/r/privatelink_endpoint_serverless.html.markdown

themantissa · 2022-11-14T17:48:33Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+This feature is not available for M0 free clusters, M2, and M5 clusters. To learn more about which features are unavailable, see [Atlas M0 (Free Cluster), M2, and M5 Limitations.](https://www.mongodb.com/docs/atlas/reference/free-shared-limitations/#std-label-atlas-free-tier)
+## Example Usage
+
+### Basic


More a nit but if there's a "Basic" I expect an advanced option. But this doesn't really have an advanced option. Not blocking but probably better to remove it or rename it something like "AWS Example".

themantissa · 2022-11-14T17:50:34Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+	provider_name = "AWS"
+}
+
+


This is still missing the AWS block. Azure has one so just need this like that.

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

themantissa · 2022-11-14T17:53:03Z

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

+	name         = "test-db"
+	provider_settings_backing_provider_name = "AZURE"
+	provider_settings_provider_name = "SERVERLESS"
+	provider_settings_region_name = "US_EAST_1"


Azure doesn't have a US_EAST_1.

Suggested change

provider_settings_region_name = "US_EAST_1"

provider_settings_region_name = "US_EAST"

themantissa · 2022-11-14T17:54:56Z

website/docs/d/privatelink_endpoint_service_serverless.html.markdown

+	name         = "test-db"
+	provider_settings_backing_provider_name = "AZURE"
+	provider_settings_provider_name = "SERVERLESS"
+	provider_settings_region_name = "US_EAST_1"


There is no US_EAST_1 in Azure: https://www.mongodb.com/docs/atlas/reference/microsoft-azure/#std-label-microsoft-azure

Suggested change

provider_settings_region_name = "US_EAST_1"

provider_settings_region_name = "US_EAST"

themantissa · 2022-11-14T18:48:23Z

website/docs/r/privatelink_endpoint_serverless.html.markdown

+## Attributes Reference
+
+In addition to all arguments above, the following attributes are exported:
+* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.


Since both AWS and Azure just remove the AWS comment. Also id returned is 24 - copied this from the original docs: https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/returnAllPrivateEndpointsForOneServerlessInstance

Suggested change

* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - Unique 24-hexadecimal digit string that identifies the private endpoint.

themantissa · 2022-11-14T18:53:47Z

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

+
+* `project_id` - (Required) Unique 24-digit hexadecimal string that identifies the project.
+* `instance_name` - (Required) Human-readable label that identifies the serverless instance.
+* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.


Similar to above - remove AWS. Also 24, not 22:

Suggested change

* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

* `endpoint_id` - (Required) Unique 24-hexadecimal digit string that identifies the private endpoint.

website/docs/r/privatelink_endpoint_serverless.html.markdown

website/docs/r/privatelink_endpoint_service_serverless.html.markdown

…_service_serverless

themantissa

LGTM! Thanks!

website/docs/d/privatelink_endpoints_service_serverless.html.markdown

* INTMDB-444: Add support for termination protection enabled feature (#912) * Initial commit of termination_protection_enabled support * Lint dead code removal * INTMDB-364 Add support for serverless private endpoints (AWS + Azure) (#913) * Add support for serverless private endpoints * Correct lint error * Update 1.5.0-upgrade-guide.html.markdown * Update 1.5.0-upgrade-guide.html.markdown * Add documentation for serverless endpoints * Update Schema timeout values * Update documentation * Add privatelink_endpoints_service_serverless datasource and documentation * Fix lint error * Add support for Azure private endpoints * Provide additional examples for AWS and AZURE standardize parameter cloud_provider_endpoint_id * Additional examples * Tidy up docs * Update Doc region for Azure * Add AWS aws_vpc_endpoint to link to mongodbatlas_privatelink_endpoint_service_serverless * Remove Extra note Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: Zuhair Ahmed <[email protected]>

martinstibbe added 3 commits October 17, 2022 12:37

Add support for serverless private endpoints

d3eb725

Merge branch 'master' into INTMDB-364

223bc85

Correct lint error

eff840f

martinstibbe requested a review from a team as a code owner November 9, 2022 19:33

Zuhairahmed self-requested a review November 9, 2022 21:51

Zuhairahmed added 2 commits November 9, 2022 17:51

Update 1.5.0-upgrade-guide.html.markdown

8f6bf4f

Update 1.5.0-upgrade-guide.html.markdown

0ae1193

Zuhairahmed suggested changes Nov 9, 2022

View reviewed changes

mongodbatlas/data_source_mongodbatlas_privatelink_endpoint_service_serverless.go Show resolved Hide resolved

mongodbatlas/resource_mongodbatlas_privatelink_endpoint_serverless.go Outdated Show resolved Hide resolved

Zuhairahmed requested a review from themantissa November 9, 2022 23:58

martinstibbe added 3 commits November 9, 2022 19:23

Add documentation for serverless endpoints

9ecf9f4

Merge branch 'INTMDB-364' of https://github.com/mongodb/terraform-pro…

3801484

…vider-mongodbatlas into INTMDB-364

Update Schema timeout values

cc5e7e5

Zuhairahmed reviewed Nov 10, 2022

View reviewed changes

andreaangiolillo approved these changes Nov 10, 2022

View reviewed changes

Update documentation

7af4a6a

martinstibbe requested a review from Zuhairahmed November 10, 2022 14:29

Add privatelink_endpoints_service_serverless datasource and documenta…

cc1e11f

…tion

themantissa requested changes Nov 10, 2022

View reviewed changes

Zuhairahmed changed the title ~~INTMDB-364 Add support for serverless private endpoints (AWS)~~ INTMDB-364 Add support for serverless private endpoints (AWS + Azure) Nov 10, 2022

Fix lint error

887e65f

Zuhairahmed approved these changes Nov 10, 2022

View reviewed changes

Add support for Azure private endpoints

c4f38e8

martinstibbe requested review from Zuhairahmed and andreaangiolillo November 12, 2022 01:56

Provide additional examples for AWS and AZURE standardize parameter c…

255a79d

…loud_provider_endpoint_id

Zuhairahmed reviewed Nov 13, 2022

View reviewed changes

Zuhairahmed self-requested a review November 13, 2022 22:24

Additional examples

56f7541

Zuhairahmed approved these changes Nov 14, 2022

View reviewed changes

Tidy up docs

98bb521

andreaangiolillo approved these changes Nov 14, 2022

View reviewed changes

martinstibbe requested a review from themantissa November 14, 2022 17:53

themantissa requested changes Nov 14, 2022

View reviewed changes

martinstibbe added 2 commits November 14, 2022 18:51

Update Doc region for Azure

f99b888

Add AWS aws_vpc_endpoint to link to mongodbatlas_privatelink_endpoint…

d6ae475

…_service_serverless

martinstibbe requested a review from themantissa November 15, 2022 01:12

Remove Extra note

16d1a66

themantissa approved these changes Nov 15, 2022

View reviewed changes

website/docs/d/privatelink_endpoints_service_serverless.html.markdown Show resolved Hide resolved

martinstibbe merged commit 2a5f149 into release-staging-v1.6.0 Nov 15, 2022

martinstibbe deleted the INTMDB-364 branch November 15, 2022 18:45

	For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Serverless-Private-Endpoints/operation/createOnePrivateEndpointForOneServerlessInstance/) and [MongoDB Atlas API - Online Archive](https://docs.atlas.mongodb.com/reference/api/online-archive/) Documentation.
	For more information see: [MongoDB Atlas API - Serverless Private Endpoints](https://www.mongodb.com/docs/atlas/reference/api/serverless-private-endpoints-get-one/).

	* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service. MongoDB Cloud returns null while it creates the endpoint service.
	* `endpoint_service_name` - Unique string that identifies the PrivateLink endpoint service.

	* `instance_name` - (Required) Human-readable label that identifies the serverless instance associated with the tenant endpoint
	* `instance_name` - (Required) Human-readable label that identifies the serverless instance

	* `instance_name` - (Required) Serverless instance name to attach private
	* `instance_name` - (Required) Human-readable label that identifies the serverless instance

	# Data Source: privatelink_endpoint_service_serverless
	# Resource: privatelink_endpoint_service_serverless

	# Data Source: privatelink_endpoint_serverless
	# Resource: privatelink_endpoint_serverless

	* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [\|aws\| PrivateLink](https://aws.amazon.com/privatelink/) feature.
	* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

	* `instance_name` - (Required)Human-readable label that identifies the serverless instance.
	* `instance_name` - (Required) Human-readable label that identifies the serverless instance.

	* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [\|aws\| PrivateLink](https://aws.amazon.com/privatelink/) feature.
	* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.

	provider_settings_region_name = "US_EAST_1"
	provider_settings_region_name = "US_EAST"

	* `endpoint_id` - Unique 22-character alphanumeric string that identifies the private endpoint. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.
	* `endpoint_id` - Unique 24-hexadecimal digit string that identifies the private endpoint.

	* `endpoint_id` - (Required) Unique 22-character alphanumeric string that identifies the private endpoint's network interface. Atlas supports AWS private endpoints using the [AWS PrivateLink](https://aws.amazon.com/privatelink/) feature.
	* `endpoint_id` - (Required) Unique 24-hexadecimal digit string that identifies the private endpoint.

INTMDB-364 Add support for serverless private endpoints (AWS + Azure) #913

INTMDB-364 Add support for serverless private endpoints (AWS + Azure) #913

Conversation

martinstibbe commented Nov 9, 2022 • edited Loading

Description

Type of change:

Required Checklist:

Further comments

Zuhairahmed left a comment • edited Loading

Choose a reason for hiding this comment

Zuhairahmed left a comment

Choose a reason for hiding this comment

andreaangiolillo left a comment

Choose a reason for hiding this comment

Zuhairahmed commented Nov 10, 2022

themantissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zuhairahmed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zuhairahmed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreaangiolillo left a comment

Choose a reason for hiding this comment

themantissa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

themantissa left a comment

Choose a reason for hiding this comment

martinstibbe commented Nov 9, 2022 •

edited

Loading

Zuhairahmed left a comment •

edited

Loading