Skip to content

INTMDB-444: Add support for termination protection enabled feature #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

martinstibbe
Copy link
Contributor

@martinstibbe martinstibbe commented Nov 9, 2022

Description

INTMDB-444: Add support for termination protection enabled feature for Advanced Clusters , Clusters, and Serverless Instances

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@martinstibbe martinstibbe requested a review from a team as a code owner November 9, 2022 19:31
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy day this is finally an option! LGTM

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstibbe martinstibbe merged commit 3b31e66 into release-staging-v1.6.0 Nov 11, 2022
@martinstibbe martinstibbe deleted the INTMDB-444 branch November 11, 2022 14:22
Zuhairahmed added a commit that referenced this pull request Nov 15, 2022
* INTMDB-444: Add support for termination protection enabled feature (#912)

* Initial commit of termination_protection_enabled support

* Lint dead code removal

* INTMDB-364 Add support for serverless private endpoints (AWS + Azure) (#913)

* Add support for serverless private endpoints

* Correct lint error

* Update 1.5.0-upgrade-guide.html.markdown

* Update 1.5.0-upgrade-guide.html.markdown

* Add documentation for serverless endpoints

* Update Schema timeout values

* Update documentation

* Add privatelink_endpoints_service_serverless datasource and documentation

* Fix lint error

* Add support for Azure private endpoints

* Provide additional examples for AWS and AZURE standardize parameter cloud_provider_endpoint_id

* Additional examples

* Tidy up docs

* Update Doc region for Azure

* Add AWS aws_vpc_endpoint to link to mongodbatlas_privatelink_endpoint_service_serverless

* Remove Extra note

Co-authored-by: Zuhair Ahmed <[email protected]>

Co-authored-by: Zuhair Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants