INTMDB-300: Advance Cluster resource ignoring the autoscaling options #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinstibbe
requested review from
coderGo93,
andreaangiolillo and
abner-dou
as code owners
themantissa
requested review from
themantissa
and removed request for
coderGo93 and
abner-dou
themantissa
approved these changes
Feb 28, 2022
Comment on lines
845
to
846
| apiObject.DiskGB = apiObject2 | ||
| apiObject.Compute = apiObject3 |
There was a problem hiding this comment.
This name is not helpful. Could we rename apiObject to advancedAutoScaling, apiObject2 to diskGB and apiObject3 to compute ?
| @@ -842,6 +842,9 @@ func expandRegionConfigAutoScaling(tfList []interface{}) *matlas.AdvancedAutoSca | |||
| apiObject3.MaxInstanceSize = v.(string) | |||
| } | |||
|
|
|||
| apiObject.DiskGB = apiObject2 | |||
| apiObject.Compute = apiObject3 | |||
|
|
|||
There was a problem hiding this comment.
Could we update resource_mongodbatlas_advanced_cluster_test.go to include the autoscaling attributes? Thanks!
andreaangiolillo
approved these changes
Mar 2, 2022
guineveresaenger
pushed a commit
to pulumi/terraform-provider-mongodbatlas
that referenced
this pull request
Sep 13, 2022
…mongodb#686) * Advance Cluster resource ignoring the autoscaling options * Refactor and add additional test case * Add test parameters * Add support for autoscaling parameter tests * lint fix Co-authored-by: admin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments