INTMDB-300: Advance Cluster resource ignoring the autoscaling options (#686)

* Advance Cluster resource ignoring the autoscaling options

* Refactor and add additional test case

* Add test parameters

* Add support for autoscaling parameter tests

* lint fix

Co-authored-by: admin <[email protected]>

Author: martinstibbe

.gitignore

@@ -1,6 +1,7 @@
 *.dll
 *.exe
 .DS_Store
+.vscode
 example.tf
 terraform.tfplan
 terraform.tfstate

mongodbatlas/resource_mongodbatlas_advanced_cluster.go

@@ -825,27 +825,30 @@ func expandRegionConfigAutoScaling(tfList []interface{}) *matlas.AdvancedAutoSca
 
 	tfMap, _ := tfList[0].(map[string]interface{})
 
-	apiObject := &matlas.AdvancedAutoScaling{}
-	apiObject2 := &matlas.DiskGB{}
-	apiObject3 := &matlas.Compute{}
+	advancedAutoScaling := &matlas.AdvancedAutoScaling{}
+	diskGB := &matlas.DiskGB{}
+	compute := &matlas.Compute{}
 
 	if v, ok := tfMap["disk_gb_enabled"]; ok {
-		apiObject2.Enabled = pointy.Bool(v.(bool))
+		diskGB.Enabled = pointy.Bool(v.(bool))
 	}
 	if v, ok := tfMap["compute_enabled"]; ok {
-		apiObject3.Enabled = pointy.Bool(v.(bool))
+		compute.Enabled = pointy.Bool(v.(bool))
 	}
 	if v, ok := tfMap["compute_scale_down_enabled"]; ok {
-		apiObject3.ScaleDownEnabled = pointy.Bool(v.(bool))
+		compute.ScaleDownEnabled = pointy.Bool(v.(bool))
 	}
 	if v, ok := tfMap["compute_min_instance_size"]; ok {
-		apiObject3.MinInstanceSize = v.(string)
+		compute.MinInstanceSize = v.(string)
 	}
 	if v, ok := tfMap["compute_max_instance_size"]; ok {
-		apiObject3.MaxInstanceSize = v.(string)
+		compute.MaxInstanceSize = v.(string)
 	}
 
-	return apiObject
+	advancedAutoScaling.DiskGB = diskGB
+	advancedAutoScaling.Compute = compute
+
+	return advancedAutoScaling
 }
 
 func flattenAdvancedReplicationSpec(ctx context.Context, apiObject *matlas.AdvancedReplicationSpec, tfMapObject map[string]interface{},

mongodbatlas/resource_mongodbatlas_advanced_cluster_test.go

@@ -386,6 +386,50 @@ func TestAccResourceMongoDBAtlasAdvancedCluster_DefaultWrite(t *testing.T) {
 	})
 }
 
+func TestAccMongoDBAtlasAdvancedClusterConfig_ReplicationSpecsAutoScaling(t *testing.T) {
+	var (
+		cluster      matlas.AdvancedCluster
+		resourceName = "mongodbatlas_advanced_cluster.test"
+		projectID    = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
+		rName        = acctest.RandomWithPrefix("test-acc")
+		rNameUpdated = acctest.RandomWithPrefix("test-acc")
+		autoScaling  = &matlas.AutoScaling{
+			Compute:       &matlas.Compute{Enabled: pointy.Bool(false), MaxInstanceSize: ""},
+			DiskGBEnabled: pointy.Bool(true),
+		}
+		autoScalingUpdated = &matlas.AutoScaling{
+			Compute:       &matlas.Compute{Enabled: pointy.Bool(true), MaxInstanceSize: "M20"},
+			DiskGBEnabled: pointy.Bool(true),
+		}
+	)
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviderFactories,
+		CheckDestroy:      testAccCheckMongoDBAtlasAdvancedClusterDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccMongoDBAtlasAdvancedClusterConfigReplicationSpecsAutoScaling(projectID, rName, autoScaling),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMongoDBAtlasAdvancedClusterExists(resourceName, &cluster),
+					testAccCheckMongoDBAtlasAdvancedClusterAttributes(&cluster, rName),
+					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.0.region_configs.#"),
+					testAccCheckMongoDBAtlasAdvancedClusterScaling(&cluster, *autoScaling.Compute.Enabled),
+				),
+			},
+			{
+				Config: testAccMongoDBAtlasAdvancedClusterConfigReplicationSpecsAutoScaling(projectID, rNameUpdated, autoScalingUpdated),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckMongoDBAtlasAdvancedClusterExists(resourceName, &cluster),
+					testAccCheckMongoDBAtlasAdvancedClusterAttributes(&cluster, rNameUpdated),
+					resource.TestCheckResourceAttrSet(resourceName, "replication_specs.0.region_configs.#"),
+					testAccCheckMongoDBAtlasAdvancedClusterScaling(&cluster, *autoScalingUpdated.Compute.Enabled),
+				),
+			},
+		},
+	})
+}
+
 func testAccCheckMongoDBAtlasAdvancedClusterExists(resourceName string, cluster *matlas.AdvancedCluster) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		conn := testAccProvider.Meta().(*MongoDBClient).Atlas
@@ -422,6 +466,16 @@ func testAccCheckMongoDBAtlasAdvancedClusterAttributes(cluster *matlas.AdvancedC
 	}
 }
 
+func testAccCheckMongoDBAtlasAdvancedClusterScaling(cluster *matlas.AdvancedCluster, computeEnabled bool) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		if *cluster.ReplicationSpecs[0].RegionConfigs[0].AutoScaling.Compute.Enabled != computeEnabled {
+			return fmt.Errorf("compute_enabled: %d", cluster.ReplicationSpecs[0].RegionConfigs[0].AutoScaling.Compute.Enabled)
+		}
+
+		return nil
+	}
+}
+
 func testAccCheckMongoDBAtlasAdvancedClusterDestroy(s *terraform.State) error {
 	conn := testAccProvider.Meta().(*MongoDBClient).Atlas
 
@@ -666,3 +720,38 @@ resource "mongodbatlas_advanced_cluster" "test" {
 	`, projectID, name, *p.JavascriptEnabled, p.MinimumEnabledTLSProtocol, *p.NoTableScan,
 		*p.OplogSizeMB, *p.SampleSizeBIConnector, *p.SampleRefreshIntervalBIConnector, p.DefaultReadConcern, p.DefaultWriteConcern)
 }
+
+func testAccMongoDBAtlasAdvancedClusterConfigReplicationSpecsAutoScaling(projectID, name string, p *matlas.AutoScaling) string {
+	return fmt.Sprintf(`
+resource "mongodbatlas_advanced_cluster" "test" {
+  project_id             = %[1]q
+  name                   = %[2]q
+  cluster_type           = "REPLICASET"
+  mongo_db_major_version = "4.4"
+
+   replication_specs {
+    region_configs {
+      electable_specs {
+        instance_size = "M10"
+        node_count    = 3
+      }
+      analytics_specs {
+        instance_size = "M10"
+        node_count    = 1
+      }
+	  auto_scaling {
+        compute_enabled = %[3]t
+        disk_gb_enabled = %[4]t
+		compute_max_instance_size = %[5]q
+	  }
+      provider_name = "AWS"
+      priority      = 7
+      region_name   = "US_EAST_1"
+    }
+  }
+
+
+}
+
+	`, projectID, name, *p.Compute.Enabled, *p.DiskGBEnabled, p.Compute.MaxInstanceSize)
+}