Skip to content

Fix timeout in acctest #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2021
Merged

Fix timeout in acctest #602

merged 3 commits into from
Nov 12, 2021

Conversation

abner-dou
Copy link
Contributor

@abner-dou abner-dou commented Nov 11, 2021 •
edited
Loading

Description

A fix was apply to change the timeout on acctest (now is necessary a env var called ACCTEST_TIMEOUT), also a minor changes to serverless debug messages was made

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou self-assigned this Nov 11, 2021
coderGo93
coderGo93 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the understanding that there will still be at least state timeouts per slack discussion.

Thank you for the text edits as well - this shows we all really need to keep an eye out better for misses like this.

@themantissa themantissa requested review from a team, threebee and gssbzn and removed request for andreaangiolillo and a team November 11, 2021 17:24
@themantissa
Copy link
Collaborator

@threebee and @gssbzn sorry to add you both but we are way behind on tests and hoping this will help remove failures we are seeing. Would like one of you to give it a look before proceeding, if possible.

gssbzn
gssbzn approved these changes Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abner-dou abner-dou changed the title fix timeout in serverless and private endpoint Fix timeout in acctest Nov 11, 2021
@abner-dou abner-dou requested a review from gssbzn November 11, 2021 18:18
coderGo93
coderGo93 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abner-dou abner-dou merged commit b6cf3a6 into master Nov 12, 2021
@abner-dou abner-dou deleted the serverless-fix branch November 12, 2021 00:45
abner-dou added a commit that referenced this pull request Nov 15, 2021
@abner-dou
Fix timeout in acctest (#602)
305df75 
* fix timeout in serverless and private endpoint

* change timeout in testacc

* added default timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 coderGo93 approved these changes

@thetonymaster thetonymaster Awaiting requested review from thetonymaster

@threebee threebee Awaiting requested review from threebee threebee was automatically assigned from mongodb/apix

@gssbzn gssbzn Awaiting requested review from gssbzn

Assignees

@abner-dou abner-dou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abner-dou @themantissa @gssbzn @coderGo93