Fix timeout in acctest (#602)

* fix timeout in serverless and private endpoint

* change timeout in testacc

* added default timeout

Author: abner-dou

.github/workflows/automated-test-acceptances.yml

@@ -79,4 +79,5 @@ jobs:
           GCP_KEY_VERSION_RESOURCE_ID: ${{ secrets.GCP_KEY_VERSION_RESOURCE_ID }}
           CA_CERT: ${{ secrets.CA_CERT }}
           MONGODB_ATLAS_ENABLE_BETA: ${{ secrets.MONGODB_ATLAS_ENABLE_BETA }}
+          ACCTEST_TIMEOUT: ${{ secrets.ACCTEST_TIMEOUT }}
         run: make testacc

GNUmakefile

@@ -1,4 +1,5 @@
 TEST?=$$(go list ./... | grep -v /integrationtesting)
+ACCTEST_TIMEOUT?=300m
 GOFMT_FILES?=$$(find . -name '*.go' |grep -v vendor)
 PKG_NAME=mongodbatlas
 
@@ -36,7 +37,7 @@ test: fmtcheck
 .PHONY: testacc
 testacc: fmtcheck
 	@$(eval VERSION=acc)
-	TF_ACC=1 go test $(TEST) -v -parallel 20 $(TESTARGS) -timeout 300m -cover -ldflags="$(LINKER_FLAGS)"
+	TF_ACC=1 go test $(TEST) -v -parallel 20 $(TESTARGS) -timeout $(ACCTEST_TIMEOUT) -cover -ldflags="$(LINKER_FLAGS)"
 
 .PHONY: fmt
 fmt:

mongodbatlas/resource_mongodbatlas_privatelink_endpoint.go

@@ -13,7 +13,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
-
 	matlas "go.mongodb.org/atlas/mongodbatlas"
 )
 

mongodbatlas/resource_mongodbatlas_serverless_instance.go

@@ -138,7 +138,7 @@ func resourceMongoDBAtlasServerlessInstanceDelete(ctx context.Context, d *schema
 		return diag.FromErr(fmt.Errorf("error deleting MongoDB Serverless Instance (%s): %s", serverlessName, err))
 	}
 
-	log.Println("[INFO] Waiting for MongoDB Cluster to be destroyed")
+	log.Println("[INFO] Waiting for MongoDB Serverless Instance to be destroyed")
 
 	stateConf := &resource.StateChangeConf{
 		Pending:    []string{"IDLE", "CREATING", "UPDATING", "REPAIRING", "DELETING"},
@@ -176,7 +176,7 @@ func resourceMongoDBAtlasServerlessInstanceRead(ctx context.Context, d *schema.R
 			return nil
 		}
 
-		return diag.Errorf("error getting search index information: %s", err)
+		return diag.Errorf("error getting serverless instance information: %s", err)
 	}
 
 	if err := d.Set("id", serverlessInstance.ID); err != nil {
@@ -253,7 +253,7 @@ func resourceMongoDBAtlasServerlessInstanceCreate(ctx context.Context, d *schema
 	// Wait, catching any errors
 	_, err = stateConf.WaitForStateContext(ctx)
 	if err != nil {
-		return diag.FromErr(fmt.Errorf(errorClusterCreate, err))
+		return diag.Errorf("error creating MongoDB Serverless Instance: %s", err)
 	}
 
 	d.SetId(encodeStateID(map[string]string{