fix: Fix acceptance tests and Delete for stream_instance acceptance tests #3447

lantoli · 2025-06-30T16:02:32Z

Description

Fix acceptance tests and Delete for stream_processor acceptance tests.

Wait in Delete until stream_processor is deleted.

Link to any related issue(s): CLOUDP-328093

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Copilot

Pull Request Overview

This PR fixes acceptance tests and improves deletion handling for stream_processor resources by waiting until the resource is fully deleted and reducing resource usage by switching to SP10.

Adjusted timeouts (min timeout and delay) in the state transition wait function
Updated acceptance tests to include a stream_config with SP10 tier
Modified the Delete function to wait for the resource deletion status

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/service/streamprocessor/state_transition.go	Updates timeout settings in the state transition function
internal/service/streamprocessor/resource_test.go	Adds stream_config with tier "SP10" for tests
internal/service/streamprocessor/resource.go	Improves Delete function by waiting for deletion transition
internal/service/streamconnection/resource_stream_connection_test.go	Updates test configuration with stream_config (tier SP10)
.changelog/3447.txt	Adds release note for the deletion fix

Comments suppressed due to low confidence (1)

internal/service/streamprocessor/state_transition.go:35

[nitpick] Consider updating or expanding the nearby comment to explain the rationale behind increasing the MinTimeout and setting a Delay of 10 seconds for better clarity on the new configuration.

		MinTimeout: 10 * time.Second,

github-actions · 2025-07-01T07:35:56Z

APIx bot: a message has been sent to Docs Slack channel

lantoli · 2025-07-01T07:38:42Z

internal/service/streamprocessor/state_transition.go

-		MinTimeout: 3 * time.Second,
-		Delay:      0,
+		MinTimeout: 10 * time.Second,
+		Delay:      10 * time.Second,


give some delay time to reduce flaky tests

Adding 10 seconds to the delete operation of regular users for fixing our tests seems strange. Lets sync offline just to check if we can assess other options.

sure, but I think this will also be helpful in Prod to fix a race condition in the API when it's under load

Makes sense to me to add this 👍

waiting for Atlas team to see if this is a good approach or they would fix it in their side

internal/service/streamprocessor/resource.go

oarbusi

LGTM

EspenAlbert

Very nice

lantoli · 2025-07-01T10:35:32Z

use of SP10 instead of SP30 moved to: #3453

This reverts commit 19b6aad.

* master: chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452) chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453) chore: JSON attributes in auto-generated resources (#3445) chore: Updates repository to use supported Terraform versions (#3450)

lmkerbey-mdb · 2025-07-01T14:50:55Z

.changelog/3447.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/mongodbatlas_stream_processor: Fixes Delete to wait until the resource is deleted


Suggested change

resource/mongodbatlas_stream_processor: Fixes Delete to wait until the resource is deleted

resource/mongodbatlas_stream_processor: Fixes Delete to wait until the resource is deleted.

@lmkerbey-mdb hi, we don't end changelogs with a period, see other examples in: https://github.com/mongodb/terraform-provider-mongodbatlas/tree/master/.changelog

so CHANGELOG is formed like this: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/CHANGELOG.md

AgustinBettati

LGTM once we get confirmation from streams team that delete is effectively a LRO which requires followup polling

AgustinBettati · 2025-07-01T16:04:04Z

internal/service/streamprocessor/resource.go

 		resp.Diagnostics.AddError("error deleting resource", err.Error())
 		return
 	}
+	_, err := WaitStateTransition(ctx, params, connV2.StreamsApi, []string{InitiatingState, CreatingState, CreatedState, StartedState, StoppedState}, []string{DroppedState})
+	if apiError, _ := admin.AsError(err); apiError.GetError() == http.StatusBadRequest {


here we can check for BadRequest or NotFound (what would be the correct implementation) just to be future proof

good idea, changed here: 2b47d75

lantoli added 4 commits June 30, 2025 18:01

use SP10 instead of default SP30 for stream_instance

19b6aad

wait in delete

e2ed029

changelog

5814b44

more time to wait

5ff18cb

lantoli changed the title ~~chore: Use SP10 instead of default SP30 for stream_instance acceptance tests~~ fix: Fix acceptance tests and Delete for stream_instance acceptance tests Jul 1, 2025

github-actions bot added the bug label Jul 1, 2025

lantoli marked this pull request as ready for review July 1, 2025 07:35

Copilot AI review requested due to automatic review settings July 1, 2025 07:35

lantoli requested review from a team as code owners July 1, 2025 07:35

Copilot AI reviewed Jul 1, 2025

View reviewed changes

lantoli commented Jul 1, 2025

View reviewed changes

oarbusi reviewed Jul 1, 2025

View reviewed changes

internal/service/streamprocessor/resource.go Show resolved Hide resolved

oarbusi approved these changes Jul 1, 2025

View reviewed changes

EspenAlbert approved these changes Jul 1, 2025

View reviewed changes

lantoli added 3 commits July 1, 2025 12:46

Revert "use SP10 instead of default SP30 for stream_instance"

157761d

This reverts commit 19b6aad.

use 3s delay

5737914

lmkerbey-mdb requested changes Jul 1, 2025

View reviewed changes

AgustinBettati reviewed Jul 1, 2025

View reviewed changes

also check 404

2b47d75

lmkerbey-mdb approved these changes Jul 1, 2025

View reviewed changes

lantoli added the not_stale Not stale issue or PR label Jul 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix acceptance tests and Delete for stream_instance acceptance tests #3447

fix: Fix acceptance tests and Delete for stream_instance acceptance tests #3447

lantoli commented Jun 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

lantoli Jul 1, 2025

Uh oh!

AgustinBettati Jul 1, 2025

Uh oh!

lantoli Jul 1, 2025 •

edited

Loading

Uh oh!

EspenAlbert Jul 1, 2025

Uh oh!

lantoli Jul 1, 2025

Uh oh!

Uh oh!

oarbusi left a comment

Uh oh!

EspenAlbert left a comment

Uh oh!

lantoli commented Jul 1, 2025

Uh oh!

lmkerbey-mdb Jul 1, 2025

Uh oh!

lantoli Jul 1, 2025

Uh oh!

AgustinBettati left a comment

Uh oh!

AgustinBettati Jul 1, 2025

Uh oh!

lantoli Jul 1, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,3 @@
		```release-note:bug
		resource/mongodbatlas_stream_processor: Fixes Delete to wait until the resource is deleted

fix: Fix acceptance tests and Delete for stream_instance acceptance tests #3447

Are you sure you want to change the base?

fix: Fix acceptance tests and Delete for stream_instance acceptance tests #3447

Conversation

lantoli commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lantoli Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oarbusi left a comment

Choose a reason for hiding this comment

Uh oh!

EspenAlbert left a comment

Choose a reason for hiding this comment

Uh oh!

lantoli commented Jul 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AgustinBettati left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lantoli commented Jun 30, 2025 •

edited

Loading

lantoli Jul 1, 2025 •

edited

Loading