Skip to content

chore: JSON attributes in auto-generated resources #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 1, 2025

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jun 28, 2025

Description

JSON attributes in auto-generated resources.

  • Create stream_processor_api which has pipeline and stats JSON attributes.

Link to any related issue(s): CLOUDP-327779

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli
Copy link
Member Author

lantoli commented Jun 30, 2025

snyk false positive

"pipeline": schema.ListAttribute{
Optional: true,
MarkdownDescription: "Stream aggregation pipeline you want to apply to your streaming data.",
ElementType: jsontypes.NormalizedType{},
Copy link
Member Author

@lantoli lantoli Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example JSON custom type in array

"stats": schema.StringAttribute{
Computed: true,
MarkdownDescription: "The stats associated with the stream processor.",
CustomType: jsontypes.NormalizedType{},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example JSON custom type

@lantoli lantoli marked this pull request as ready for review June 30, 2025 15:17
@lantoli lantoli requested a review from a team as a code owner June 30, 2025 15:17
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, covered all aspects of the generation flow. Also nice to see stream_processor generated 💯

Description *string
DeprecationMessage *string
Name stringcase.SnakeCaseString
CustomType *CustomType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking more for the future of having this model more IaC-agnostic, this could potentially be a property within the string type clarifying that it must be handled as a dynamic json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the beginning I had it more coupled to string but then I thought that custom types could also have different underlaying types apart from string in the future, that's why I prefered to keep it separately

@lantoli lantoli merged commit 318a075 into master Jul 1, 2025
41 of 42 checks passed
@lantoli lantoli deleted the CLOUDP-327779_autogen_json branch July 1, 2025 09:27
lantoli added a commit that referenced this pull request Jul 1, 2025
* master:
  chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)
  chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)
  chore: JSON attributes in auto-generated resources (#3445)
  chore: Updates repository to use supported Terraform versions (#3450)
lantoli added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
lantoli added a commit that referenced this pull request Jul 4, 2025
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

* chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457)

* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: svc-apix-Bot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
lantoli added a commit that referenced this pull request Jul 4, 2025
* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

* Added `users` attribute, modified test and docs.

* Updated doc

* chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457)

* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

* Fixed test

* Added changelog

---------

Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: svc-apix-Bot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
svc-apix-Bot added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
lantoli added a commit that referenced this pull request Jul 4, 2025
* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* chore: Docs team review improvements in dev branches (#3466)

* TEMPORARY send to test channel

* don't notify docs team if label skip-docs-notification

* TEMPORARY doc change

* add label skip label in update dev branches GHA

* Revert "TEMPORARY doc change"

This reverts commit de69883.

* Revert "TEMPORARY send to test channel"

This reverts commit c7e2746.

* detect changes

* don't create the PR is no new changes

* fix linter

* add step names

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

* chore: Update CLOUDP-320243-dev-2.0.0 from master (#3457)

* chore: Creates temporary workflow to create a test tag using Github actions (#3440)

* chore: Use rebase instead of merge to update dev branches (#3442)

* use rebase instead of merge to update dev branches

* Update .github/workflows/update-dev-branches.yml

Co-authored-by: Copilot <[email protected]>

* improve doc

---------

Co-authored-by: Copilot <[email protected]>

* chore: Updates repository to use supported Terraform versions (#3450)

Co-authored-by: maastha <[email protected]>

* chore: JSON attributes in auto-generated resources (#3445)

* stream_processor_api config

* marshal JSON custom type

* generate JSON custom type

* formatGoFile

* generated code

* acc test

* fix resouce.tmpl imports

* revert changes to template

* add import for custom types

* wait

* marshal tests

* autogen tests

* acc test with update of equivalent pipeline JSON

* unmarshal test for custom type list

* marshal error test

* join acc tests

* update generated code

* fix marshal tests

* fix delete config

* same config as curated resource

* chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)

* use SP10 instead of default SP30 for stream_instance

* fix linter

* Revert "fix linter"

This reverts commit 46270c0.

* chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)

* use JSON custom type

* fix linter

* chore: Updates Atlas Go SDK (#3446)

* build(deps): bump go.mongodb.org/atlas-sdk

* sdk changes

---------

Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>

* doc: Updates Terraform Compatibility Matrix documentation (#3449)

Co-authored-by: maastha <[email protected]>

* chore: Remove `links` attributes in auto-generated resources (#3455)

* remove links attributes

* move comment

* chore: Fixes broken link because of ending parenthesis. (#3448)

* chore: Fixes broken link because of ending parenthesis.

* using link markdown syntax to avoid broken link

---------

Co-authored-by: Agustin Bettati <[email protected]>

* feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)

* add send_user_provided_resource_tags

* changelog

* fmt

* docs and example

* test

* refactor

* rename files

* new line

* chore: Updates CHANGELOG.md for #3454

* chore: Singletons in auto-generated resources (#3458)

* initial auditing_api and maintenance_window_api generation

* fix unmarshal for empty JSON

* improve maintenance_window_api

* checkDestroy in manual resource tests

* explicit version header

* check apiResp is not nil

* support FixedRequestBody

* auditing except delete

* support FixedRequestBody

* comment in MakeApiError

* comment Unmarshal

* use same flow as in SDK

* rename FixedRequestBody to StaticRequestBody

* codegen tests

* revert unneeded test

* lowering timeout value to ensure creation fails consistently (#3462)

* doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)

* fixing inconsistent documentation

* remove human-readable term in external_group_id attribute

* fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)

* chore: Add windsurf ignore

* fix: Standardizes API params with WithParams pattern and IntPtr conversion

* chore: Adds changelog file

* refactor: use ListBackupExportJobsWithParams for export job listing

* chore: Updates CHANGELOG.md for #3459

* feat: Adds `users` attribute to `mongodbatlas_project` singular data source (#3439)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Update docs/data-sources/project.md

* Update .changelog/3439.txt

Co-authored-by: Leo Antoli <[email protected]>

* PR comments

* Fix

* Arguments fixed

* Fix constant

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>

* feat: Adds users attribute to mongodbatlas_projects plural data source (#3451)

* WIP

* Fixed acceptance test

* Added a comment

* Added changelog

* Added users attribute to projects data source

* Added changelog and fixed docs

* Factored out users schema

* Refactored schemas and fixed test and doc

* Minor code review suggestions and fixed doc

---------

Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

---------

Co-authored-by: maastha <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: oarbusi <[email protected]>
Co-authored-by: Oriol Arbusi Abadal <[email protected]>
Co-authored-by: Marco Suma <[email protected]>
Co-authored-by: Agustin Bettati <[email protected]>
Co-authored-by: Espen Albert <[email protected]>
Co-authored-by: Cristina Sánchez <[email protected]>
Co-authored-by: Cristina Sánchez Sánchez <[email protected]>
lantoli added a commit that referenced this pull request Jul 4, 2025
* master:
  chore: Docs team review improvements in dev branches (#3466)
  chore: Updates CHANGELOG.md for #3459
  fix: Avoids 0 itemsPerPage and pageNum when the args are missing in plural data sources (#3459)
  doc: Fixing inconsistent docs in `federated_settings_org_role_mapping` associated to required attributes (#3460)
  lowering timeout value to ensure creation fails consistently (#3462)
  chore: Singletons in auto-generated resources (#3458)
  chore: Updates CHANGELOG.md for #3454
  feat: Adds `send_user_provided_resource_tags` attribute for `mongodbatlas_third_party_integration` (#3454)
  chore: Fixes broken link because of ending parenthesis. (#3448)
  chore: Remove `links` attributes in auto-generated resources (#3455)
  doc: Updates Terraform Compatibility Matrix documentation (#3449)
  chore: Updates Atlas Go SDK (#3446)
  chore: Replace fwtypes.JSONStringType with jsontypes.NormalizedType (#3452)
  chore: Use SP10 instead of default SP30 for stream_instance acceptance tests (#3453)
  chore: JSON attributes in auto-generated resources (#3445)
  chore: Updates repository to use supported Terraform versions (#3450)
  chore: Use rebase instead of merge to update dev branches (#3442)
  chore: Creates temporary workflow to create a test tag using Github actions (#3440)

# Conflicts:
#	.github/workflows/update-dev-branches.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants