Skip to content

Cleaned vendored deps #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Cleaned vendored deps #272

merged 1 commit into from
Jul 23, 2020

Conversation

MihaiBojin
Copy link
Contributor

Description

Separate PR to clean vendored deps and tidy the go.mod file.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@ghost ghost added the size/XXL label Jul 23, 2020
@MihaiBojin MihaiBojin mentioned this pull request Jul 23, 2020
Merged
10 tasks
gssbzn
gssbzn approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PacoDw
PacoDw approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themantissa
themantissa approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - gave quick overview look.

@MihaiBojin MihaiBojin merged commit 8bbf4e8 into master Jul 23, 2020
@MihaiBojin MihaiBojin deleted the feature/clean-vendored branch July 23, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa approved these changes

@PacoDw PacoDw PacoDw approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MihaiBojin @gssbzn @themantissa @PacoDw