Skip to content

Replaced the digest auth library with one that supports SHA-256 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Replaced the digest auth library with one that supports SHA-256 #271

merged 1 commit into from
Jul 23, 2020

Conversation

MihaiBojin
Copy link
Contributor

@MihaiBojin MihaiBojin commented Jul 23, 2020 •
edited
Loading

Description

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@ghost ghost added the size/XXL label Jul 23, 2020
@MihaiBojin MihaiBojin changed the title Replaced the digest auth library with one with support for SHA-256 Replaced the digest auth library with one that supports SHA-256 Jul 23, 2020
gssbzn
gssbzn approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaiBojin
Copy link
Contributor Author

I ran the cleanup operations in #272 to make this PR easier to review.

PacoDw
PacoDw approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@PacoDw PacoDw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

themantissa
themantissa approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for knocking this out.

@MihaiBojin MihaiBojin force-pushed the feature/update-digest-library branch from 8add0f9 to 7b103f4 Compare July 23, 2020 16:52
@ghost ghost added size/XL dependencies and removed size/XXL labels Jul 23, 2020
gssbzn
gssbzn approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restamp

@MihaiBojin MihaiBojin merged commit b1d5bfa into master Jul 23, 2020
@MihaiBojin MihaiBojin deleted the feature/update-digest-library branch July 23, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@themantissa themantissa themantissa approved these changes

@PacoDw PacoDw PacoDw approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees
No one assigned
Labels
dependencies size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MihaiBojin @gssbzn @themantissa @PacoDw