Skip to content

INTMDB-867: Update release.yml #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

INTMDB-867: Update release.yml #1239

merged 1 commit into from
Jun 15, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 15, 2023 •
edited
Loading

Description

Reverting release.yml changes in #1144 as they seem the root cause of the recent release failure 9532843110

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 15, 2023 07:19
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 15, 2023 07:19
maastha
maastha approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

martinstibbe
martinstibbe approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstibbe martinstibbe merged commit 047a0e3 into master Jun 15, 2023
@martinstibbe martinstibbe deleted the INTMDB-868 branch June 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinstibbe martinstibbe martinstibbe approved these changes

@maastha maastha maastha approved these changes

@Zuhairahmed Zuhairahmed Awaiting requested review from Zuhairahmed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaangiolillo @martinstibbe @maastha