INTMDB-788: Add Code-health action #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+8
to
+15
| while IFS= read -r -d '' f; do | ||
| if [ "${1-}" = "diff" ]; then | ||
| echo "$f" | ||
| cat "$f" | node_modules/.bin/codedown hcl | terraform fmt -diff=true - | ||
| < "$f" node_modules/.bin/codedown hcl | terraform fmt -diff=true - | ||
| else | ||
| cat "$f" | node_modules/.bin/codedown hcl | terraform fmt -check=true - || problems=true && echo "Formatting errors in $f" | ||
| < "$f" node_modules/.bin/codedown hcl | terraform fmt -check=true - || { problems=true && echo "Formatting errors in $f"; } | ||
| fi | ||
| done | ||
| done < <(find website -name '*.markdown' -print0) |
There was a problem hiding this comment.
Hi @martinstibbe, is this script still used? when I run make websitefmtcheck the script says that there are some markdown with formatting errors 😕
Should we run this script as part of the code-health action?
There was a problem hiding this comment.
Since TF registry website test stopped working as the deprecated the local site document testing if we do not call this one via a GH action may not be used golangci-lint run is in current workflows
.github/workflows/automated-test.yml
Outdated
| pull_request: | ||
|
|
||
| jobs: | ||
| tests: |
There was a problem hiding this comment.
move to code-health
| @@ -1,22 +0,0 @@ | |||
| --- | |||
| name: golangci-lint | |||
There was a problem hiding this comment.
moved to code-health
Zuhairahmed
approved these changes
Apr 26, 2023
…ogs is set to true, when copying backups to other regions (#1150)
|
Hi @martinstibbe 👋 Could you review this PR when you have time, please? I am not sure if I can merge it after your comment |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed changes:
Create a
code-healthworkflow similar to what we have in CFN and CDKThis new workflow runs the following jobs:
Type of change:
Required Checklist:
Further comments
Next Steps: