-
Notifications
You must be signed in to change notification settings - Fork 230
chore(deps): bump @mongodb-js/devtools-connect, driver, bson #7096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, it's fine to do a one-off PR, but the typical way is that we update a driver version in mongosh (or devtools-connect first if necessary), then bump it in Compass along with its mongosh dependencies |
Oh yes, need to pull this in too. Seems like I need to fix a TS issue too 👀 ty for the pointers |
I think if you want to do this, you could take over #7094 from me – I'm focusing on getting its mongosh counterpart green right now, so feel free to do that if you have the time |
@addaleax rebased and targeting your branch now this should be oidc + driver upgrades |
'mongodbLogComponentSeverities', | ||
'mongodbLogMaxDocumentLength', | ||
'mongodbLogPath', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only option that wasn't in alphabetical order 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the alphabetization of @mongodb-js/compass-app-registry ! I missed that when we renamed it from hadron.
Description
Checklist
Motivation and Context
I would like to pull this fix: mongodb/node-mongodb-native#4473 into compass-web, I believe our websockets are generating "plain" errors avoiding the driver's retryability
Open Questions
Dependents
Types of changes