Skip to content

chore(deps): bump @mongodb-js/devtools-connect, driver, bson #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jul 7, 2025

Description

  • Q: Is there a specific way or pattern to file an upgrade bump like this on JIRA? (the previous ticket I found was tied to "release mongosh")

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

I would like to pull this fix: mongodb/node-mongodb-native#4473 into compass-web, I believe our websockets are generating "plain" errors avoiding the driver's retryability

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax
Copy link
Collaborator

addaleax commented Jul 7, 2025

  • Q: Is there a specific way or pattern to file an upgrade bump like this on JIRA? (the previous ticket I found was tied to "release mongosh")

Yeah, it's fine to do a one-off PR, but the typical way is that we update a driver version in mongosh (or devtools-connect first if necessary), then bump it in Compass along with its mongosh dependencies

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Jul 7, 2025

devtools-connect first

Oh yes, need to pull this in too.

Seems like I need to fix a TS issue too 👀 ty for the pointers

@addaleax
Copy link
Collaborator

addaleax commented Jul 7, 2025

devtools-connect first

Oh yes, need to pull this in too.

I think if you want to do this, you could take over #7094 from me – I'm focusing on getting its mongosh counterpart green right now, so feel free to do that if you have the time

@nbbeeken nbbeeken changed the base branch from main to 2194-dev July 7, 2025 22:05
@nbbeeken nbbeeken changed the title chore(deps): bump driver, bson chore(deps): bump @mongodb-js/devtools-connect, driver, bson Jul 7, 2025
@nbbeeken nbbeeken marked this pull request as ready for review July 7, 2025 22:07
@nbbeeken nbbeeken requested a review from a team as a code owner July 7, 2025 22:07
@nbbeeken nbbeeken added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jul 7, 2025
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Jul 7, 2025

@addaleax rebased and targeting your branch now this should be oidc + driver upgrades

Base automatically changed from 2194-dev to main July 10, 2025 21:14
'mongodbLogComponentSeverities',
'mongodbLogMaxDocumentLength',
'mongodbLogPath',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only option that wasn't in alphabetical order 😅

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the alphabetization of @mongodb-js/compass-app-registry ! I missed that when we renamed it from hadron.

@nbbeeken nbbeeken merged commit bfd0211 into main Jul 11, 2025
56 of 58 checks passed
@nbbeeken nbbeeken deleted the driver-bump branch July 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants