Skip to content

feat(deps): bump oidc-plugin to 2.0.0 MONGOSH-2194 #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 10, 2025
Merged

feat(deps): bump oidc-plugin to 2.0.0 MONGOSH-2194 #7094

merged 9 commits into from
Jul 10, 2025

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Jul 7, 2025

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jul 7, 2025
@addaleax addaleax marked this pull request as ready for review July 10, 2025 10:41
@Copilot Copilot AI review requested due to automatic review settings July 10, 2025 10:41
@addaleax addaleax requested a review from a team as a code owner July 10, 2025 10:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the OIDC plugin dependency from version 1.x to 2.0.0, which introduces breaking changes in how HTTP customization is handled. The update replaces the customHttpOptions.agent pattern with a more flexible customFetch approach and updates proxy handling mechanisms.

Key changes:

  • Updates OIDC plugin from v1.1.8 to v2.0.0 across multiple packages
  • Replaces customHttpOptions.agent with customFetch for HTTP customization
  • Simplifies proxy configuration by using applyProxyToOIDC directly with proxy options

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/data-service/src/data-service.ts Updates OIDC option filtering to include new customFetch and customHttpOptions
packages/data-service/src/connect-mongo-client.ts Replaces agent-based proxy setup with applyProxyToOIDC option
packages/data-service/src/connect-mongo-client.spec.ts Updates test expectations to reflect new proxy configuration structure
packages/atlas-service/src/main.ts Migrates from customHttpOptions.agent to customFetch pattern
packages/compass-e2e-tests/tests/atlas-login.test.ts Updates error message expectation and adds .only to test
configs/webpack-config-compass/src/index.ts Removes manual jose library resolution
Multiple package.json files Bumps OIDC plugin and related dependencies to newer versions
Comments suppressed due to low confidence (1)

packages/compass-e2e-tests/tests/atlas-login.test.ts:254

  • The test has .only modifier which will cause other tests in this suite to be skipped. This should be removed before merging to ensure all tests run in CI.
    it.only('should show toast with error if sign in failed', async function () {

@addaleax addaleax marked this pull request as draft July 10, 2025 10:42
@addaleax addaleax marked this pull request as ready for review July 10, 2025 13:03
@addaleax addaleax merged commit 643aaa2 into main Jul 10, 2025
56 of 58 checks passed
@addaleax addaleax deleted the 2194-dev branch July 10, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants