-
Notifications
You must be signed in to change notification settings - Fork 229
feat(deps): bump oidc-plugin to 2.0.0 MONGOSH-2194 #7094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the OIDC plugin dependency from version 1.x to 2.0.0, which introduces breaking changes in how HTTP customization is handled. The update replaces the customHttpOptions.agent
pattern with a more flexible customFetch
approach and updates proxy handling mechanisms.
Key changes:
- Updates OIDC plugin from v1.1.8 to v2.0.0 across multiple packages
- Replaces
customHttpOptions.agent
withcustomFetch
for HTTP customization - Simplifies proxy configuration by using
applyProxyToOIDC
directly with proxy options
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/data-service/src/data-service.ts | Updates OIDC option filtering to include new customFetch and customHttpOptions |
packages/data-service/src/connect-mongo-client.ts | Replaces agent-based proxy setup with applyProxyToOIDC option |
packages/data-service/src/connect-mongo-client.spec.ts | Updates test expectations to reflect new proxy configuration structure |
packages/atlas-service/src/main.ts | Migrates from customHttpOptions.agent to customFetch pattern |
packages/compass-e2e-tests/tests/atlas-login.test.ts | Updates error message expectation and adds .only to test |
configs/webpack-config-compass/src/index.ts | Removes manual jose library resolution |
Multiple package.json files | Bumps OIDC plugin and related dependencies to newer versions |
Comments suppressed due to low confidence (1)
packages/compass-e2e-tests/tests/atlas-login.test.ts:254
- The test has
.only
modifier which will cause other tests in this suite to be skipped. This should be removed before merging to ensure all tests run in CI.
it.only('should show toast with error if sign in failed', async function () {
This reverts commit 7b7eee6.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes