Updating EntityRequest.Base.template with code fix for response headers issue #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New changes will propagate the fix for having response headers and status codes in request objects when UpdateAsync method is called in entities
MIchaelMainer
requested changes
May 28, 2019
There was a problem hiding this comment.
This looks good. The main thing to look for is that we are generating valid code, that we aren't breaking existing code, and we are only affecting the intended files.
The only change I request is that we add a /// comment for the expected exception.
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/exception
Another thing you'll need to do is to build the client library with the updated files. Do this by copying the generated files into their appropriate directory in the client repo. Can you verify that this builds? You'll also be able to validate your test at this point. If all is good, go ahead and make a PR in the SDK repo for the updated code files.
|
added 2 commits
May 29, 2019 14:55
- Adding the exception documentation in IEntityRequest.Base - Refactoring in EntityRequest.Base to include this if includeSendParams == true so that it shows in the async UpdateAsync() method.
MIchaelMainer
approved these changes
May 29, 2019
MIchaelMainer
added a commit
that referenced
this pull request
Jun 5, 2019
* Add NamespacePrefix that's used as the class name prefix for generating ObjC models. * Added preprocessors for nav properties * Support updating the default base Graph URL via the endpointVersion argument. * add rule to add containsTarget=true to labelPolicy navigation * Convert edm.Decimal to number * Handle CRLF in doc annotations as code comments. * Updated request builder interfaces to inherit from common interface * Added IBaseRequestBuilder to consumers of IRequestBuilder.Base * Applied <auto-generated/> comment tag to all generated c# files. * Added comments to all complex types class definitions. * Fix for enum naming for camelcased+underscore scenario (#194) * Fix duplicate PHP enum name generation * Add back camelcase-ization to limit the changes. * Added preprocess rule for new intune navigation (#195) * Updating EntityRequest.Base.template with code fix for response headers issue (#202) * Updating template with response headers fix. * New changes will propagate the fix for having response headers and status codes in request objects when UpdateAsync method is called in entities * Adding the exception documentation in IEntityRequest.Base * Refactoring in EntityRequest.Base to include this if includeSendParams == true so that it shows in the async UpdateAsync() method. * Fixed spacing indentation (#204) * New changes will propagate the fix for having response headers and status codes in request objects when UpdateAsync method is called in entities * Adding exception description to documentation * Adding and refactoring exception documentation * Adding the exception documentation in IEntityRequest.Base * Refactoring in EntityRequest.Base to include this if includeSendParams == true so that it shows in the async UpdateAsync() method. * Space Indentation Fixes * Fixed bugs for publishing in definitely typed repo (#203) * Add contains target for new entities. (#205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Updates the EntityRequest.Base.template with the code fix that checks response headers and status codes in the AdditionalData property tag of entities and throws an error (if response headers or status code properties are found).
This fix is for task: microsoftgraph/msgraph-sdk-dotnet#426