Fix for enum naming for camelcased+underscore scenario #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
approved these changes
Apr 29, 2019
MIchaelMainer
added a commit
that referenced
this pull request
Jun 5, 2019
* Add NamespacePrefix that's used as the class name prefix for generating ObjC models. * Added preprocessors for nav properties * Support updating the default base Graph URL via the endpointVersion argument. * add rule to add containsTarget=true to labelPolicy navigation * Convert edm.Decimal to number * Handle CRLF in doc annotations as code comments. * Updated request builder interfaces to inherit from common interface * Added IBaseRequestBuilder to consumers of IRequestBuilder.Base * Applied <auto-generated/> comment tag to all generated c# files. * Added comments to all complex types class definitions. * Fix for enum naming for camelcased+underscore scenario (#194) * Fix duplicate PHP enum name generation * Add back camelcase-ization to limit the changes. * Added preprocess rule for new intune navigation (#195) * Updating EntityRequest.Base.template with code fix for response headers issue (#202) * Updating template with response headers fix. * New changes will propagate the fix for having response headers and status codes in request objects when UpdateAsync method is called in entities * Adding the exception documentation in IEntityRequest.Base * Refactoring in EntityRequest.Base to include this if includeSendParams == true so that it shows in the async UpdateAsync() method. * Fixed spacing indentation (#204) * New changes will propagate the fix for having response headers and status codes in request objects when UpdateAsync method is called in entities * Adding exception description to documentation * Adding and refactoring exception documentation * Adding the exception documentation in IEntityRequest.Base * Refactoring in EntityRequest.Base to include this if includeSendParams == true so that it shows in the async UpdateAsync() method. * Space Indentation Fixes * Fixed bugs for publishing in definitely typed repo (#203) * Add contains target for new entities. (#205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only impacts 2 entities in beta. It basically makes the underscoring rule also be applicable to existing underscores. This fix unblocks beta generation for PHP. This fixes PHP#167.
This change fixes the generation scenario where two different member names are similar by having camelcase with preceding underscores like this:
The above member names were both being generated as REMOTE_CONTROL_SOFTWARE. This fix differentiates the two as seen in image 1. Image 2 shows the other enum affected by this template change.
Image 1. Change made to WindowsMalwareCategory.php by this change. This is the target that is blocking beta generation
Image 2. Change made to DeviceManagementSubscriptions.php by this change.
