Skip to content

Show specific task provider progress and allow providers to be canceled #90236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

Show specific task provider progress and allow providers to be canceled #90236

merged 1 commit into from
Feb 7, 2020

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 7, 2020 •
edited
Loading

Part of #90087

@alexr00 alexr00 added this to the February 2020 milestone Feb 7, 2020
@alexr00 alexr00 requested a review from chrmarti February 7, 2020 14:35
@alexr00 alexr00 self-assigned this Feb 7, 2020
@alexr00
Copy link
Member Author

alexr00 commented Feb 7, 2020

@chrmarti when I hide the custom quick pick button, the quick pick loses focus and then hides. Because of this, I added focusOnInput. Could you review the two quickInput files to see if you're ok with this change?

chrmarti
chrmarti approved these changes Feb 7, 2020
View reviewed changes
Copy link
Collaborator

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe QuickInput could detect the case and pass the focus automatically to the input field?

Not sure if that's easy to do, the current change is good for now.

@alexr00 alexr00 merged commit 68f2ab6 into master Feb 7, 2020
@alexr00 alexr00 deleted the alexr00/cancelTaskProvider branch February 7, 2020 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrmarti chrmarti chrmarti approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@alexr00 @chrmarti