Skip to content

Improve quick pick for tasks since task providers can make it too slow. #90087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexr00 opened this issue Feb 5, 2020 · 3 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality on-testplan tasks Task system issues
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 5, 2020

We have a temporary fix for the release for #90015 but we need to do something better long term.

@alexr00 alexr00 added feature-request Request for new features or functionality tasks Task system issues labels Feb 5, 2020
@alexr00 alexr00 added this to the February 2020 milestone Feb 5, 2020
@alexr00 alexr00 self-assigned this Feb 5, 2020
@alexr00 alexr00 modified the milestones: February 2020, March 2020 Feb 21, 2020
alexr00 added a commit that referenced this issue Mar 5, 2020
so that a real task can be generated from the data stored. This enables us to fetch recently used tasks before all providers run.
Part of #90087
@bpasero
Copy link
Member

bpasero commented Mar 16, 2020

@alexr00 while working on quick access for tasks I noticed that we seem to be having 2 pickers for the same thing (?):

Task quick open:
image

"Run Task" picker:
image

Is that intentional? Should the one be merged into the other?

@alexr00
Copy link
Member Author

alexr00 commented Mar 16, 2020

Yes, they do not share much code :( as part of improving the quick pick I will converge them.

@bpasero
Copy link
Member

bpasero commented Mar 16, 2020

@alexr00 sounds good, please only change taskQuickAccess and leave the other one because I plan to delete those old ones soon.

alexr00 added a commit that referenced this issue Mar 26, 2020
alexr00 added a commit that referenced this issue Mar 27, 2020
@alexr00 alexr00 closed this as completed Mar 27, 2020
@alexr00 alexr00 reopened this Mar 30, 2020
@alexr00 alexr00 closed this as completed Mar 30, 2020
@alexr00 alexr00 mentioned this issue Mar 30, 2020
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants