Skip to content

Update XDP to latest prerelease, dedupdupduplicate xdp install/uninstall #5085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/prepare-machine.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@ function Install-Xdp-Driver {
Write-Host "Downloading XDP msi"
$MsiPath = Join-Path $ArtifactsPath "xdp.msi"
Invoke-WebRequest -Uri (Get-Content (Join-Path $PSScriptRoot "xdp.json") | ConvertFrom-Json).installer -OutFile $MsiPath
Write-Host "Installing XDP driver certificate"
$CertFileName = Join-Path $ArtifactsPath 'xdp.cer'
Get-AuthenticodeSignature $MsiPath | Select-Object -ExpandProperty SignerCertificate | Export-Certificate -Type CERT -FilePath $CertFileName
Import-Certificate -FilePath $CertFileName -CertStoreLocation 'cert:\localmachine\root'
Import-Certificate -FilePath $CertFileName -CertStoreLocation 'cert:\localmachine\trustedpublisher'
Write-Host "Installing XDP driver"
msiexec.exe /i $MsiPath /quiet | Out-Null
}
Expand Down
8 changes: 1 addition & 7 deletions scripts/quic_callback.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,7 @@ if ($Command.Contains("/home/secnetperf/_work/quic/artifacts/bin/linux/x64_Relea
./artifacts/bin/windows/x64_Release_schannel/secnetperf -exec:$mode -io:$io -stats:$stats
} elseif ($Command.Contains("Install_XDP")) {
Write-Host "Executing command: Install_XDP"
Write-Host "(SERVER) Downloading XDP installer"
$installerUri = $Command.Split(";")[1]
$msiPath = Repo-Path "xdp.msi"
Invoke-WebRequest -Uri $installerUri -OutFile $msiPath -UseBasicParsing
Write-Host "(SERVER) Installing XDP. Msi path: $msiPath"
msiexec.exe /i $msiPath /quiet | Out-Host
Wait-DriverStarted "xdp" 10000
.\scripts\prepare-machine.ps1 -InstallXdpDriver
} elseif ($Command -eq "Install_Kernel") {
Write-Host "Executing command: Install_Kernel"
$KernelDir = Repo-Path "./artifacts/bin/winkernel/x64_Release_schannel"
Expand Down
24 changes: 5 additions & 19 deletions scripts/secnetperf-helpers.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -135,44 +135,30 @@ function Wait-DriverStarted {
# Download and install XDP on both local and remote machines.
function Install-XDP {
param ($Session, $RemoteDir)
$installerUri = (Get-Content (Join-Path $PSScriptRoot "xdp.json") | ConvertFrom-Json).installer
$msiPath = Repo-Path "artifacts/xdp.msi"
Write-Host "Downloading XDP installer"
whoami
Invoke-WebRequest -Uri $installerUri -OutFile $msiPath -UseBasicParsing
Write-Host "Installing XDP driver locally"
msiexec.exe /i $msiPath /quiet | Out-Null
$Size = Get-FileHash $msiPath
Write-Host "MSI file hash: $Size"
Wait-DriverStarted "xdp" 10000
.\scripts\prepare-machine.ps1 -InstallXdpDriver
Write-Host "Installing XDP driver on peer"

if ($Session -eq "NOT_SUPPORTED") {
NetperfSendCommand "Install_XDP;$installerUri"
NetperfSendCommand "Install_XDP"
NetperfWaitServerFinishExecution
return
}

$remoteMsiPath = Join-Path $RemoteDir "artifacts/xdp.msi"
Copy-Item -ToSession $Session $msiPath -Destination $remoteMsiPath
$WaitDriverStartedStr = "${function:Wait-DriverStarted}"
Invoke-Command -Session $Session -ScriptBlock {
msiexec.exe /i $Using:remoteMsiPath /quiet | Out-Host
$WaitDriverStarted = [scriptblock]::Create($Using:WaitDriverStartedStr)
& $WaitDriverStarted xdp 10000
& "$Using:RemoteDir\scripts\prepare-machine.ps1" -InstallXdpDriver
}
}

# Uninstalls the XDP driver on both local and remote machines.
function Uninstall-XDP {
param ($Session, $RemoteDir)
$msiPath = Repo-Path "artifacts/xdp.msi"
$remoteMsiPath = Join-Path $RemoteDir "artifacts/xdp.msi"
Write-Host "Uninstalling XDP driver locally"
try { msiexec.exe /x $msiPath /quiet | Out-Null } catch {}
try { .\scripts\prepare-machine.ps1 -UninstallXdp } catch {}
Write-Host "Uninstalling XDP driver on peer"
Invoke-Command -Session $Session -ScriptBlock {
try { msiexec.exe /x $Using:remoteMsiPath /quiet | Out-Null } catch {}
try { & "$Using:RemoteDir\scripts\prepare-machine.ps1" -UninstallXdp } catch {}
}
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/xdp.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"installer": "https://github.com/microsoft/xdp-for-windows/releases/download/v1.1.0/xdp-for-windows.x64.1.1.0.msi"
"installer": "https://github.com/microsoft/xdp-for-windows/releases/download/v1.2.0-prerelease-793dc2a0/xdp-for-windows.x64.1.2.0-prerelease-793dc2a0.msi"
}
2 changes: 1 addition & 1 deletion submodules/xdp-for-windows
Submodule xdp-for-windows updated 94 files
+3 −1 .azure/onebranch.test.yml
+3 −0 .azure/templates/build.yml
+3 −1 .azure/templates/spinxsk.yml
+3 −1 .azure/templates/tests.yml
+14 −6 .github/actions/xskperf/action.yml
+1 −1 .github/workflows/build.yml
+146 −74 .github/workflows/ci.yml
+9 −0 docs/api/driver-txqueueconfig.md
+2 −1 docs/release.md
+12 −0 docs/usage.md
+1 −0 published/external/afxdp.h
+23 −18 published/external/afxdp_experimental.h
+10 −1 published/external/afxdp_helper.h
+16 −0 published/external/xdp/details/txqueueconfig.h
+1 −1 published/external/xdp/ebpfhook.h
+41 −0 published/external/xdp/framechecksum.h
+27 −0 published/external/xdp/framechecksumextension.h
+62 −0 published/external/xdp/framelayout.h
+27 −0 published/external/xdp/framelayoutextension.h
+0 −82 published/external/xdp/offload.h
+6 −0 published/external/xdp/txqueueconfig.h
+13 −0 published/external/xdpapi_experimental.h
+4 −0 published/external/xdpddi.h
+1 −13 published/private/xdpif.h
+4 −0 published/private/xdptxqueue_internal.h
+0 −1 readme.md
+2 −0 samples/directory.build.props
+9 −1 src/nuget/nuget.vcxproj
+10 −8 src/nuget/xdp-for-windows.nuspec.in
+0 −3 src/onebranch/onebranch.vcxproj
+20 −16 src/rtl/inc/xdprtl.h
+6 −8 src/xdp.props
+39 −1 src/xdp/extensionset.c
+11 −0 src/xdp/extensionset.h
+4 −0 src/xdp/precomp.h
+2 −3 src/xdp/program.c
+1 −0 src/xdp/rx.c
+277 −57 src/xdp/tx.c
+21 −0 src/xdp/tx.h
+2 −1 src/xdp/xdp.vcxproj
+617 −73 src/xdp/xsk.c
+65 −0 src/xdpetw/xdpetw.man
+0 −92 src/xdpetwplugin/DataModel/ETW/XdpEtwDataReader.cs
+0 −51 src/xdpetwplugin/DataModel/ETW/XdpEtwEvent.cs
+0 −118 src/xdpetwplugin/DataModel/XdpEvent.cs
+0 −10 src/xdpetwplugin/Properties/launchSettings.json
+0 −62 src/xdpetwplugin/XdpEtwSource.cs
+0 −55 src/xdpetwplugin/XdpEventCooker.cs
+0 −100 src/xdpetwplugin/XdpEventParser.cs
+0 −26 src/xdpetwplugin/XdpEventProcessor.cs
+0 −23 src/xdpetwplugin/xdpetwplugin.csproj
+0 −24 src/xdpetwplugin/xdpetwplugin.sln
+7 −4 src/xdpinstaller/xdpinstaller.wixproj
+1 −1 src/xdplwf/bind.c
+13 −0 src/xdplwf/offload.c
+5 −0 src/xdplwf/offload.h
+178 −1 src/xdplwf/offloadtask.c
+13 −0 src/xdplwf/offloadtask.h
+2 −0 src/xdplwf/oid.h
+5 −0 src/xdplwf/precomp.h
+178 −117 src/xdplwf/recv.c
+181 −0 src/xdplwf/send.c
+12 −0 src/xdplwf/send.h
+5 −3 src/xdppcw/inc/xdppcw.h
+26 −0 src/xdppcw/xdppcw.man
+10 −7 src/xdpruntime/xdp-for-windows-runtime.nuspec.in
+6 −0 src/xdpruntime/xdp-for-windows-runtime.props
+12 −2 src/xdpruntime/xdp-setup.ps1
+9 −1 src/xdpruntime/xdpruntime.vcxproj
+1 −1 submodules/cxplat
+1 −1 submodules/net-offloads
+1 −1 submodules/wil
+2 −0 test/directory.build.props
+498 −68 test/functional/lib/tests.cpp
+19 −0 test/functional/lib/tests.h
+28 −0 test/functional/taef/tests.cpp
+191 −0 test/ringperf/ringperf.c
+22 −0 test/ringperf/ringperf.vcxproj
+470 −3 test/spinxsk/spinxsk.c
+1 −0 test/spinxsk/spinxsk.vcxproj
+1 −1 test/xdpmp/xdpmp.md
+84 −0 test/xskbench/xskbench.c
+67 −11 tools/common.ps1
+9 −5 tools/functional.ps1
+17 −9 tools/perfcompare.ps1
+13 −19 tools/prepare-machine.ps1
+23 −0 tools/ringperf.ps1
+125 −0 tools/rxfilterperf.ps1
+115 −2 tools/setup.ps1
+55 −17 tools/spinxsk.ps1
+53 −0 tools/summarize-perf.ps1
+9 −0 tools/xskperf.ps1
+25 −7 tools/xskperfsuite.ps1
+10 −0 xdp.sln
Loading