Update XDP to latest prerelease, dedupdupduplicate xdp install/uninstall #5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
changed the title
mtfriesen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5085 +/- ##
==========================================
+ Coverage 85.81% 86.06% +0.24%
==========================================
Files 59 59
Lines 17995 17995
==========================================
+ Hits 15443 15487 +44
+ Misses 2552 2508 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfriesen
changed the title
nibanks
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
The steps to install and uninstall XDP are implemented in several different places, each one subtly different. This is contrary to the software engineering best practice of reducing duplication and having a single point of maintenance for a given piece of functionality.
For unknown reasons, each of these duplicated implementations was actually not duplicated, but subtly different.
Use one function to do one thing.
Testing
Do any existing tests cover this change? Are new tests needed?
CI.
Documentation
Is there any documentation impact for this change?
No.