Skip to content

gamecore: allow non-system32 DLLs to be loaded #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jianye-chen
Copy link
Contributor

Description

Fixes DLL load failure on gamecore, where msvcrt is shipped with application.
ref: #4883

Testing

Manually verified locally.

Documentation

N/A

msvcrt is shipped with application on gamecore

Signed-off-by: Jianye Chen <[email protected]>
@nibanks nibanks merged commit e2fc8e9 into microsoft:main May 5, 2025
282 of 284 checks passed
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (30479ed) to head (9dc3b02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5075      +/-   ##
==========================================
- Coverage   87.06%   85.98%   -1.08%     
==========================================
  Files          59       59              
  Lines       17924    17924              
==========================================
- Hits        15605    15412     -193     
- Misses       2319     2512     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jianye-chen jianye-chen deleted the bugfix/jianyechen/gamecore_needs_vcrt branch May 5, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants