Fix Windows Loader Flags #4883
Merged
Fix Windows Loader Flags #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav2699
approved these changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
- Coverage 87.30% 86.94% -0.36%
==========================================
Files 56 56
Lines 17630 17630
==========================================
- Hits 15391 15328 -63
- Misses 2239 2302 +63 ☔ View full report in Codecov by Sentry. |
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
nibanks
added a commit
that referenced
this pull request
Mar 3, 2025
|
Thanks for fixing this. I built the main branch and confirmed that the load flag is now correctly set. |
Thanks! It should also be in the two latest release branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Windows loader flags to load dependencies from system32 directory.
Testing
Manually verified locally, and CI/CD for regression checks.
Documentation
N/A - this was always the expected behavior