Skip to content

fix(a11y): remove deprecated css properties #34550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(a11y): remove deprecated css properties #34550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d47f7
fix(a11y): remove deprecated css properties
tudorpopams May 29, 2025
1ce6bc6
fixup! fix(a11y): remove deprecated css properties
tudorpopams May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-style-utilities-292d3597-40bd-4db9-8ff5-2ed771ed3ea2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests/Callout 5 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Callout.No callout width specified.default.chromium.png 2126 Changed
vr-tests/Callout.Bottom right edge.default.chromium.png 1120 Changed
vr-tests/Callout.Left bottom edge.default.chromium.png 3123 Changed
vr-tests/Callout.Bottom left edge.default.chromium.png 2181 Changed
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png 2186 Changed
vr-tests/react-charting-GaugeChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-GaugeChart.Basic.default.chromium.png 2 Changed
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 3 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

"type": "patch",
"comment": "remove deprecated css properties that show up on the v8 docsite",
"packageName": "@fluentui/style-utilities",
"email": "[email protected]",
"dependentChangeType": "patch"
}
8 changes: 4 additions & 4 deletions packages/style-utilities/etc/style-utilities.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export { DefaultFontStyles }
export { DefaultPalette }

// @public @deprecated (undocumented)
export const EdgeChromiumHighContrastSelector = "@media screen and (-ms-high-contrast: active), screen and (forced-colors: active)";
export const EdgeChromiumHighContrastSelector = "@media screen and (forced-colors: active)";

// @public (undocumented)
export const FLUENT_CDN_BASE_URL = "https://res.cdn.office.net/files/fabric-cdn-prod_20250411.001";
Expand Down Expand Up @@ -153,13 +153,13 @@ export type GlobalClassNames<IStyles> = Record<keyof IStyles, string>;
export const hiddenContentStyle: IRawStyle;

// @public (undocumented)
export const HighContrastSelector = "@media screen and (-ms-high-contrast: active), screen and (forced-colors: active)";
export const HighContrastSelector = "@media screen and (forced-colors: active)";

// @public (undocumented)
export const HighContrastSelectorBlack = "@media screen and (-ms-high-contrast: white-on-black), screen and (forced-colors: active) and (prefers-color-scheme: dark)";
export const HighContrastSelectorBlack = "@media screen and (forced-colors: active) and (prefers-color-scheme: dark)";

// @public (undocumented)
export const HighContrastSelectorWhite = "@media screen and (-ms-high-contrast: black-on-white), screen and (forced-colors: active) and (prefers-color-scheme: light)";
export const HighContrastSelectorWhite = "@media screen and (forced-colors: active) and (prefers-color-scheme: light)";

export { IAnimationStyles }

Expand Down
9 changes: 4 additions & 5 deletions packages/style-utilities/src/styles/CommonStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import type { IRawStyle } from '../MergeStyles';

export const HighContrastSelector = '@media screen and (-ms-high-contrast: active), screen and (forced-colors: active)';
export const HighContrastSelector = '@media screen and (forced-colors: active)';
export const HighContrastSelectorWhite =
// eslint-disable-next-line @fluentui/max-len
'@media screen and (-ms-high-contrast: black-on-white), screen and (forced-colors: active) and (prefers-color-scheme: light)';
'@media screen and (forced-colors: active) and (prefers-color-scheme: light)';
export const HighContrastSelectorBlack =
// eslint-disable-next-line @fluentui/max-len
'@media screen and (-ms-high-contrast: white-on-black), screen and (forced-colors: active) and (prefers-color-scheme: dark)';
'@media screen and (forced-colors: active) and (prefers-color-scheme: dark)';
/**
* @deprecated Use `HighContrastSelector`
*/
export const EdgeChromiumHighContrastSelector =
'@media screen and (-ms-high-contrast: active), screen and (forced-colors: active)';
export const EdgeChromiumHighContrastSelector = '@media screen and (forced-colors: active)';

export const ScreenWidthMinSmall = 320;
export const ScreenWidthMinMedium = 480;
Expand Down
Loading