fix(a11y): remove deprecated css properties #34550
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahgodbolt
approved these changes
May 29, 2025
tudorpopams
force-pushed
the
fix/v8-docsite-deprecated-css
branch
from
189919b to
b1d47f7
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests/Callout 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
| vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3123 | Changed |
| vr-tests/Callout.Bottom left edge.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2186 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the high-contrast media query selectors in
CommonStyles.tsto remove legacy support for the-ms-high-contrastfeature, which is specific to older versions of Microsoft browsers.These selectors are showing up on the v8 docsite and they were flagged by our a11y team.
Updates to high-contrast media queries:
HighContrastSelector: Removed the-ms-high-contrast: activecondition, keeping onlyforced-colors: activefor modern browser compatibility.HighContrastSelectorWhiteandHighContrastSelectorBlack: Updated to remove-ms-high-contrastconditions and retain onlyforced-colors: activewith appropriateprefers-color-schemeconditions.EdgeChromiumHighContrastSelector: Deprecated and simplified by removing the-ms-high-contrast: activecondition, leaving onlyforced-colors: active.