Skip to content

MSI should install drivers and services #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 8, 2022
Merged

MSI should install drivers and services #1271

merged 13 commits into from
Jul 8, 2022

Conversation

dthaler
Copy link
Collaborator

@dthaler dthaler commented Jul 7, 2022

Description

  • Make the MSI install and start ebpfcore, netebpfext, and ebpfsvc
  • Make ebpfsvc depend on ebpfcore
  • Fix bugs in create_package_data.bat script
  • Move the "packaging" source directory to "tools\setup" and the "package" build directory to "build\setup". It was getting too confusing with "packages" (for VS) plus "packaging" plus "package" all at the same level.
  • Update the MSI CMakeFiles.txt to only require cmake 3.20 which is what comes with VS 2019

Fixes #1037

Testing

Manual testing, plus CI/CD regression tests.

Documentation

This PR includes some doc changes. Docs about installing via the MSI will be done as part of issue #1149.

@dthaler dthaler force-pushed the msi branch 4 times, most recently from 30af682 to 8121237 Compare July 7, 2022 05:44
@dthaler dthaler marked this pull request as draft July 7, 2022 16:17
@dthaler dthaler force-pushed the msi branch 3 times, most recently from cea4677 to 335abb0 Compare July 8, 2022 05:09
@dthaler dthaler marked this pull request as ready for review July 8, 2022 05:30
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1271 (31c3d3c) into main (37ea274) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   82.12%   82.12%   -0.01%     
==========================================
  Files         120      120              
  Lines       20866    20866              
==========================================
- Hits        17137    17136       -1     
- Misses       3729     3730       +1     
Impacted Files Coverage Δ
tools/export_program_info/export_program_info.cpp 80.59% <ø> (ø)
tests/end_to_end/test_helper.cpp 89.03% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea274...31c3d3c. Read the comment docs.

Alan-Jowett
Alan-Jowett previously approved these changes Jul 8, 2022
dthaler added 13 commits July 8, 2022 11:56
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
this version does install the netsh helper
it does not delete the files from system32 on uninstall

Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Same as the bpf2c fuzzer. This removes 15 mins from the long pole
for CI/CD.

Signed-off-by: Dave Thaler <[email protected]>
@dthaler dthaler merged commit 85b8fd9 into microsoft:main Jul 8, 2022
@dthaler dthaler deleted the msi branch July 8, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eBPF-For-Windows MSI should install drivers and services
3 participants