-
Notifications
You must be signed in to change notification settings - Fork 250
MSI should install drivers and services #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30af682
to
8121237
Compare
cea4677
to
335abb0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
- Coverage 82.12% 82.12% -0.01%
==========================================
Files 120 120
Lines 20866 20866
==========================================
- Hits 17137 17136 -1
- Misses 3729 3730 +1
Continue to review full report at Codecov.
|
Alan-Jowett
previously approved these changes
Jul 8, 2022
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
this version does install the netsh helper it does not delete the files from system32 on uninstall Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Same as the bpf2c fuzzer. This removes 15 mins from the long pole for CI/CD. Signed-off-by: Dave Thaler <[email protected]>
Alan-Jowett
approved these changes
Jul 8, 2022
shankarseal
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1037
Testing
Manual testing, plus CI/CD regression tests.
Documentation
This PR includes some doc changes. Docs about installing via the MSI will be done as part of issue #1149.