feature: Improve error-strings rule to detect acronyms and proper nouns

rule/error_strings.go

@@ -178,21 +178,25 @@ func (lintErrorStrings) checkArg(expr *ast.CallExpr, arg int) (s *ast.BasicLit,
 func lintErrorString(s string) (isClean bool, conf float64) {
 	const basicConfidence = 0.8
 	const capConfidence = basicConfidence - 0.2
+
 	first, firstN := utf8.DecodeRuneInString(s)
 	last, _ := utf8.DecodeLastRuneInString(s)
 	if last == '.' || last == ':' || last == '!' || last == '\n' {
 		return false, basicConfidence
 	}
+
 	if unicode.IsUpper(first) {
 		// People use proper nouns and exported Go identifiers in error strings,
 		// so decrease the confidence of warnings for capitalization.
-		if len(s) <= firstN {
-			return false, capConfidence
+
+		for _, r := range s[firstN:] {
+			if unicode.IsUpper(r) {
+				return true, 0 // accept words with more than 2 capital letters (e.g. GitHub, URLs, )
+			}
 		}
+
 		// Flag strings starting with something that doesn't look like an initialism.
-		if second, _ := utf8.DecodeRuneInString(s[firstN:]); !unicode.IsUpper(second) {
-			return false, capConfidence
-		}
+		return false, capConfidence
 	}
 	return true, 0
 }

testdata/golint/error_strings.go

@@ -16,6 +16,8 @@ func g(x int) error {
 	err = fmt.Errorf("Newlines are really fun\n") // MATCH /error strings should not be capitalized or end with punctuation or a newline/
 	err = errors.New(`too much stuff.`)           // MATCH /error strings should not be capitalized or end with punctuation or a newline/
 	err = errors.New("This %d is too low", x)     // MATCH /error strings should not be capitalized or end with punctuation or a newline/
+	err = errors.New("GitHub should be ok", x)
+	err = errors.New("OTP should be ok", x)
 
 	// Non-regression test for issue #610
 	d.stack.Push(from)