Skip to content

feature: Improve error-strings rule to detect acronyms and proper nouns #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

chavacava
Copy link
Collaborator

@chavacava chavacava commented Apr 3, 2025

Closes #1264 by accepting words with more than two capital letters at the beginning of error messages

@ccoVeille
Copy link
Contributor

ccoVeille commented Apr 3, 2025

#1202 was about exported rule, I don't think it's the right issue reference

I think it was about

@chavacava chavacava requested a review from denisvmedia April 3, 2025 19:39
Copy link
Collaborator

@denisvmedia denisvmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@chavacava chavacava merged commit 02f0a40 into master Apr 8, 2025
8 checks passed
@chavacava chavacava deleted the fix/1264 branch April 8, 2025 06:19
mfederowicz pushed a commit to mfederowicz/revive that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error-strings rule to detect acronyms and proper nouns
4 participants