Use locale agnostic clojure.string/lower-case

src/toucan/db.clj

@@ -153,7 +153,7 @@
      (model-symb->ns 'CardFavorite) -> 'my-project.models.card-favorite"
   [symb]
   {:pre [(symbol? symb)]}
-  (symbol (str (models/root-namespace) \. (s/lower-case (s/replace (name symb) #"([a-z])([A-Z])" "$1-$2")))))
+  (symbol (str (models/root-namespace) \. (u/lower-case (s/replace (name symb) #"([a-z])([A-Z])" "$1-$2")))))
 
 (defn- resolve-model-from-symbol
   "Resolve the model associated with SYMB, calling `require` on its namespace if needed.
@@ -271,7 +271,11 @@
   "Compile `honeysql-from` and call `jdbc/query` against the application database. Options are passed along to
   `jdbc/query`."
   [honeysql-form & {:as options}]
-  (jdbc/query (connection) (honeysql->sql honeysql-form) options))
+  (jdbc/query (connection)
+              (honeysql->sql honeysql-form)
+              ;; FIXME: This has already been fixed in `clojure.java.jdbc`, so
+              ;;        this option can be removed when using >= 0.7.10.
+              (into options {:identifiers u/lower-case})))
 
 (defn reducible-query
   "Compile `honeysql-from` and call `jdbc/reducible-query` against the application database. Options are passed along

src/toucan/util.clj

@@ -1,6 +1,7 @@
 (ns toucan.util
   "Utility functions used by other Toucan modules."
-  (:require [clojure.string :as s]))
+  (:require [clojure.string :as s])
+  (:import java.util.Locale))
 
 (defn keyword->qualified-name
   "Return keyword K as a string, including its namespace, if any (unlike `name`).
@@ -9,3 +10,11 @@
   [k]
   (when k
     (s/replace (str k) #"^:" "")))
+
+(defn lower-case
+  "Locale-agnostic version of `clojure.string/lower-case`.
+  `clojure.string/lower-case` uses the default locale in conversions, turning
+  `ID` into `ıd`, in the Turkish locale. This function always uses the
+  `Locale/US` locale."
+  [^CharSequence s]
+  (.. s toString (toLowerCase (Locale/US))))

test/toucan/db_test.clj

@@ -1,5 +1,6 @@
 (ns toucan.db-test
-  (:require [expectations :refer :all]
+  (:require [clojure.java.jdbc :as jdbc]
+            [expectations :refer :all]
             [toucan
              [db :as db]
              [test-setup :as test]]
@@ -8,7 +9,8 @@
              [category :refer [Category]]
              [phone-number :refer [PhoneNumber]]
              [user :refer [User]]
-             [venue :refer [Venue]]]))
+             [venue :refer [Venue]]])
+  (:import java.util.Locale))
 
 ;; Test overriding quoting-style
 (expect
@@ -162,6 +164,23 @@
              :order-by [:id]
              :limit    1}))
 
+;; Test that identifiers are correctly lower cased in Turkish locale (#59)
+(expect
+  :id
+  (let [connection      (db/connection)
+        original-locale (Locale/getDefault)]
+    (try
+      (Locale/setDefault (Locale/forLanguageTag "tr"))
+      (jdbc/execute! connection "DROP TABLE IF EXISTS heroes")
+      (jdbc/execute! connection "CREATE TABLE heroes (\"ID\" SERIAL PRIMARY KEY, \"NAME\" VARCHAR(256))")
+      (jdbc/execute! connection "INSERT INTO heroes (\"NAME\") VALUES ('Batman')")
+      (let [first-row (first (db/query {:select [:ID] :from [:heroes]}))]
+        ;; If `db/query` (jdbc) uses `clojure.string/lower-case`, `:ID` will be converted to `:ıd` in Turkish locale
+        (first (keys first-row)))
+      (finally
+        (jdbc/execute! connection "DROP TABLE IF EXISTS heroes")
+        (Locale/setDefault original-locale)))))
+
 (defn- transduce-to-set
   "Process `reducible-query-result` using a transducer that puts the rows from the resultset into a set"
   [reducible-query-result]