Use locale agnostic clojure.string/lower-case
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change `clojure.string/lower-case` uses the default locale, turning (for example) "ID" into ":ıd" in the Turkish locale.
camsaul
reviewed
Aug 9, 2019
camsaul
reviewed
Aug 9, 2019
camsaul
requested changes
Aug 9, 2019
There was a problem hiding this comment.
Can you add at least one test for this that checks that a query with an INNER JOIN or the like will work correctly when the user locale is Turkish? You can copy the pattern in the do-with-us-locale fn in https://github.com/metabase/metabase to temporarily switch the locale
camsaul
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change
clojure.string/lower-caseuses the default locale,turning (for example) "ID" into ":ıd" in the Turkish locale.
@camsaul