-
Notifications
You must be signed in to change notification settings - Fork 279
chore(#9231): filter aggregate targets by period #9283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#9231): filter aggregate targets by period #9283
Conversation
Hi @latin-panda here is an summary of what I did and what's left What I have done
What is left to do
|
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Show resolved
Hide resolved
@Benmuiruri I didn't have time to do much here. This is what I did:
![]() |
Thanks for rebasing and the progress you made, I will continue with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting to see this feature almost ready for release!!
I've added some comments below
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.ts
Outdated
Show resolved
Hide resolved
0f0e074
to
d0e4330
Compare
…tiple facility_ids (#9232)
20ac9ff
to
d927ee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benmuiruri almost ready! I left some questions below and comments
I still need to do another round tomorrow, so I might send more feedback
webapp/src/ts/modules/analytics/analytics-target-aggregates-detail.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben
🤩 exciting to see this ready!! Nice job 🥳 🥳
Hi @tatilepizs 👋 . This is waiting your review when you have some time. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good @Benmuiruri, thank you! ⭐
Co-authored-by: Jennifer Q <[email protected]>
Description
After the completion of #9267 which implements the actual filtering of the Aggregate Targets through the selection of the facilities in the radio buttons.
This PR adds the feature of filtering by reporting period. This filtering will be available for all supervisors (With one facility or with multi-facility).
Video demo and details of expected content on filtering
The first half of the video shows user with multi-facilities
Ben's Health Facility
toSecond Facility
Ben's Health Facility
toBen's Health Facility - {{ Previous month }}
when you selectLast month
The second hald of the video shows user with one facility
{{ Previous month }}
on the LHS when you selectLast month
Screen.Recording.2024-08-06.at.12.19.12.mov
Mobile View
Screen.Recording.2024-08-06.at.12.25.20.mov
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.