-
Notifications
You must be signed in to change notification settings - Fork 279
feat(#9231): enable place filter aggregate targets for users with multiple facility_ids #9232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9231): enable place filter aggregate targets for users with multiple facility_ids #9232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback we reviewed during the call
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.ts
Outdated
Show resolved
Hide resolved
680feae
to
363e35f
Compare
@Benmuiruri please change the PR title from chore to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick pass and left some feedback but I still need to do a proper review specially the CSS part.
Please add unit tests to the new code.
Also make sure to test the view without this feature, including when the old design is activated to verify it still looks good (can_view_old_filter, can_view_old_actionbar)
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benmuiruri I did a quick pass and I have reviewed 50% only.
I'll review the other 50% later
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!! Almost there, just small feedback
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/components/filters/analytics-filter/analytics-filter.component.ts
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Show resolved
Hide resolved
...ests/karma/ts/modules/analytics/analytics-target-aggregates-sidebar-filter-component.spec.ts
Show resolved
Hide resolved
...ests/karma/ts/modules/analytics/analytics-target-aggregates-sidebar-filter-component.spec.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.ts
Show resolved
Hide resolved
Feedback above ⬆️ Admin user (with 1 facility assigned and no facility assigned)
Offline user (with 1 facility and 2 facilities))- Device - Mobile - Desktop - Tablet - Back button - Reload - With no aggregate permissions - Navigate target - Navigate target aggregates by changing url - should not allow and show `target aggregates are disabled`
Online user (with 1 facility and 2 facilities))- Device - Mobile - Desktop - Tablet - Back button - Reload - With no aggregate permissions - Navigate target - Navigate target aggregates by changing url - should not allow and show `target aggregates are disabled`
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes, but couldn't test since I'm running out of time for this week.
LGTM! Thanks for fixing all the feedback
…tiple facility_ids (#9232)
…tiple facility_ids (#9232)
Description
This PR :
Screenshots and Videos
Analytics Landing Page Unchanged
Targets Page unchanged
Aggregate Targets Page for user with 1 Facility unchanged - They cannot see Filter button
Aggregate Targets Page for user with 1 Facility unchanged - Mobile view
Aggregate Targets Page for user with Multi Facility - They can see Filter button
Aggregate Targets Page for user with Multi Facility - Sidebar open
Aggregate Targets Page for user with Multi Facility - Sidebar open - Mobile View
Aggregate Targets Page for user with Multi Facility - Video Demo
Screen.Recording.2024-07-11.at.14.39.02.mov
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.