-
Notifications
You must be signed in to change notification settings - Fork 288
feat(#9231): enable place filter aggregate targets for users with multiple facility_ids #9232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Benmuiruri
merged 25 commits into
9231-add-aggregate-filter
from
add-filters-aggregate-targets
Jul 16, 2024
Merged
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0fe5a36
chore: add button
Benmuiruri 7dcd7bc
chore: display sidebar
Benmuiruri 0bdc465
chore: toggle sidebar
Benmuiruri 50c0765
chore: add filter button check and update color
Benmuiruri f9b2c45
chore: some feedback
Benmuiruri 823390b
chore: delete service and clean up
Benmuiruri 23ba001
chore: kinda fix ui
Benmuiruri 1044d6b
chore: display radio buttons
Benmuiruri bc5de59
chore: css almost done
Benmuiruri 363e35f
chore: css done
Benmuiruri 4ea4334
chore: feedback
Benmuiruri 4f9683b
chore: unit tests
Benmuiruri 71f9642
chore: sidebar unit tests
Benmuiruri 36334ee
chore: more unit tests
Benmuiruri 85b5222
chore: unused var
Benmuiruri 371ba21
chore: make ci green
Benmuiruri af74db0
chore: allow multifacility user to see aggregates
Benmuiruri de6c57f
chore: fix analytics module max-width
Benmuiruri 877b760
chore: typo
Benmuiruri 0f907d5
chore: clean up
Benmuiruri d4b4a20
chore: feedback
Benmuiruri 9ad495f
chore: sonar
Benmuiruri 6351940
chore: update test
Benmuiruri 9a7723b
chore: feedback
Benmuiruri 21e6d6a
chore: fix test
Benmuiruri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
webapp/src/ts/modules/analytics/analytics-target-aggregates-detail.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
webapp/src/ts/modules/analytics/analytics-target-aggregates-sidebar-filter.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
<section class="sidebar-filter"> | ||
<div class="sidebar-backdrop" [ngClass]="{ hidden: !isOpen }" (click)="toggleSidebarFilter()"></div> <!-- //NOSONAR --> | ||
Benmuiruri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<div class="sidebar-main" [ngClass]="{ hidden: !isOpen }"> | ||
<div class="sidebar-header"> | ||
<p class="sidebar-title">Filter</p> | ||
Benmuiruri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<a class="sidebar-close fa fa-times" (click)="toggleSidebarFilter()"></a> | ||
</div> | ||
|
||
<div class="sidebar-body"> | ||
<mat-accordion multi> | ||
<div class="facility-options-container"> | ||
<div class="facility-filter-title"> | ||
<span class="facility-options-title"> {{ facilityFilterLabel | translate }} </span> | ||
</div> | ||
<ng-container *ngFor="let facility of userFacilities"> | ||
<div class="facility-option-place"> | ||
<label class="facility-option-wrapper"> | ||
<input type="radio" name="facility" [value]="facility._id" | ||
class="facility-option-radio" [(ngModel)]="selectedFacilityId" | ||
(change)="fetchAggregateTargets(facility._id)"> | ||
<span class="facility-option-label">{{ facility.name }}</span> | ||
</label> | ||
</div> | ||
</ng-container> | ||
</div> | ||
</mat-accordion> | ||
</div> | ||
|
||
<div class="sidebar-footer"> | ||
<button type="button" class="btn btn-primary" (click)="toggleSidebarFilter()">Apply</button> | ||
Benmuiruri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</div> | ||
</div> | ||
</section> | ||
|
||
<ng-template #headerTemplate let-label="label" let-filters="filters"> | ||
Benmuiruri marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<p class="title">{{ label | translate }}</p> | ||
</ng-template> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.