remove some magic numbers, clean up DCC ipv4/ipv6 global variable mess and use a union to save memory. #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 is too small of a value. It should be at least 6. I have set it to 10
Added error messages for /join and /part Fixed issue where if kirc was launched without -c option you could not send messages to the channel without using /privmsg manually.
Fixed issue where you couldn't send messages to the channel if you started kirk without -c option. Added error messages to /join and /part commands.
And hopefully fix indentation for the last time
Also remove a debug printf that somehow has sneaked in and fix indentation again
Somehow merged the wrong file
It appears that writing in nano fucked up my indentation
call slot_clear() after poll() timeout and failed accept()
fix // 'command' when using /query
|
@stefan11111 let me know when you are ready to merge. |
…o", sizeof("foo") - 1), but faster
strncmp(str, "foo", sizeof("foo") - 1) is the same as memcmp(str, "fo…
|
@mcpcpc sure. I plan to look as some more things. |
… it's a ring buffer and there is no need to memmove()
no need to free memory at exit, the kernel does this
|
@mcpcpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.