remove some magic numbers, clean up DCC ipv4/ipv6 global variable mess and use a union to save memory. (#139)

Co-authored-by: Emeka Nkurumeh <[email protected]>

Author: stefan11111

Makefile

@@ -1,11 +1,11 @@
 .POSIX:
-ALL_WARNING = -Wall -Wextra -pedantic
+ALL_WARNING = -Wall -Wextra -pedantic -std=c99
 PREFIX ?= /usr/local
 BINDIR = $(PREFIX)/bin
 MANDIR = $(PREFIX)/share/man
 
 kirc: kirc.c kirc.h
-	$(CC) $(CFLAGS) $(LDFLAGS) ${ALL_WARNING} kirc.c -o kirc
+	$(CC) $(CFLAGS) -D_FILE_OFFSET_BITS=64 $(LDFLAGS) ${ALL_WARNING} kirc.c -o kirc
 all: kirc
 
 install: kirc

README.md

@@ -15,11 +15,29 @@ Building and installing from source:
 
 Consult `man kirc` for a full list and explanation of available arguments.
 
-    kirc [-s hostname] [-p port] [-c channels] [-n nickname] [-r realname]
-         [-u username] [-k password] [-a token] [-o logfile] [-e|x|v|V]
+    kirc [-s hostname] [-p port] [-c channels] [-n nickname] [-r realname] [-a auth]
+         [-u username] [-k password] [-a token] [-o logfile] [-D directory] [-4|6|d|e|x|v|V]
 
 ## DCC
-	DCC transfers are always accpeted without user interaction and downloaded to the current directory.
+	DCC transfers are only accepted if the -d flag is passed to kirc.
+ 	If -d is passed to kirc, DCC transfers are always accpeted without user interaction
+  	and downloaded to the configured directory.
+	If no directory is set with the -D option, files are downloaded to the current directory.
+
+ ## DCC SEND
+	DCC SEND is only enabled if the -d flag is passed to kirc.
+	You can send files via DCC SEND using the folowing command:
+	/dcc <target nick> <path to file> <internal ip> <external ip> <port>
+	If you are sending files to clients outside of your lan, you must
+	make sure that the chosen port is open and forwarded to
+	the sending machine's internal address.
+	Thus is usually done from your router's settings.
+	For example:
+	/dcc dcc_client /home/user/upload/file.txt 192.168.1.100 12.34.56.78 10000
+	This command would send the file located at /home/user/upload/file.txt to the nick
+	dcc_client, assuming the sending machine's local ip is 192.168.1.100, and
+ 	the sending machine's external ip is 12.34.56.78, and that the port 10000
+  	is open and forwarded to the sending machine's local address.
 
 ## Command Aliases
 

kirc.1

@@ -45,6 +45,24 @@ Specifies the PASS connection password
 .BI \-a " auth"
 Specifies SASL PLAIN mechanism authentication token
 .TP
+.BI \-D " dir"
+Specifies DCC download directory
+.TP
+.BI \-o " logfile"
+Specifies logfile
+.TP
+.BI \-4
+Connect via ipv4 only
+.TP
+.BI \-6
+Connect via ipv6 only
+.TP
+.BI \-d
+Toggle DCC support
+.TP
+.BI \-f
+Filter ansi color codes
+.TP
 .BI \-e
 Specifies SASL EXTERNAL mechanism
 .TP
@@ -63,7 +81,7 @@ received.
 .BI /<command>
 Send message to IRC host (e.g. /JOIN, /PART, /WHOIS, etc.)
 .TP
-.BI /setprivmsg <nick>
+.BI /query " <nick>"
 Set privmsg target. Useful when sending privmsg's to a nick instead of a chan.
 .TP
 .BI // " <text>"