-
-
Notifications
You must be signed in to change notification settings - Fork 117
Clarify the meaning of "public rooms" in the room directory #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the meaning of "public rooms" in the room directory #2104
Conversation
Signed-off-by: Johannes Marbach <[email protected]>
Co-authored-by: Kim Brose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor notes, otherwise this looks good to me. Thank you!
I'd also like to explicitly highlight the transition from "public room directory" to "published room directory" as being one the ecosystem will need to adapt to. And if you could just audit the diff to make sure we're using "published room directory" vs. "room directory" in all the right places.
Co-authored-by: Andrew Morgan <[email protected]>
Co-authored-by: Andrew Morgan <[email protected]>
I'm slightly unsure how exactly to reflect this in the spec text. Or did you just mean calling it out explicitly in the changelog?
Have changed the wording accordingly in all applicable places with 9f17ab0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
…rg#2104) Signed-off-by: Johannes Marbach <[email protected]> Co-authored-by: Kim Brose <[email protected]> Co-authored-by: Andrew Morgan <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
Relates to: #633
Pull Request Checklist
Preview: https://pr2104--matrix-spec-previews.netlify.app