Skip to content

Clarify the meaning of "public rooms" in the room directory #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2025

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Mar 19, 2025

Relates to: #633

Pull Request Checklist

Preview: https://pr2104--matrix-spec-previews.netlify.app

@Johennes Johennes marked this pull request as ready for review March 19, 2025 14:00
@Johennes Johennes requested a review from a team as a code owner March 19, 2025 14:00
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notes, otherwise this looks good to me. Thank you!

I'd also like to explicitly highlight the transition from "public room directory" to "published room directory" as being one the ecosystem will need to adapt to. And if you could just audit the diff to make sure we're using "published room directory" vs. "room directory" in all the right places.

@Johennes
Copy link
Contributor Author

Johennes commented May 21, 2025

I'd also like to explicitly highlight the transition from "public room directory" to "published room directory" as being one the ecosystem will need to adapt to.

I'm slightly unsure how exactly to reflect this in the spec text. Or did you just mean calling it out explicitly in the changelog?

And if you could just audit the diff to make sure we're using "published room directory" vs. "room directory" in all the right places.

Have changed the wording accordingly in all applicable places with 9f17ab0.

@Johennes Johennes requested a review from anoadragon453 May 21, 2025 07:58
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@richvdh richvdh merged commit 2c734c3 into matrix-org:main May 21, 2025
12 checks passed
Johennes added a commit to Johennes/matrix-spec that referenced this pull request May 30, 2025
…rg#2104)

Signed-off-by: Johannes Marbach <[email protected]>
Co-authored-by: Kim Brose <[email protected]>
Co-authored-by: Andrew Morgan <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants