Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!(encryption): rename are_we_the_last_man_standing to is_last_device #4522

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore!(encryption): rename are_we_the_last_man_standing to is_last_device #4522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/matrix-sdk-ffi/src/encryption.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ impl Encryption {
}

pub async fn is_last_device(&self) -> Result<bool> {
Ok(self.inner.recovery().are_we_the_last_man_standing().await?)
Ok(self.inner.recovery().is_last_device().await?)
}

pub async fn wait_for_backup_upload_steady_state(
Expand Down
1 change: 1 addition & 0 deletions crates/matrix-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ All notable changes to this project will be documented in this file.
call `AttachmentConfig::new().thumbnail(thumbnail)` now instead.
- [**breaking**] `Room::send_attachment()` and `RoomSendQueue::send_attachment()`
now take any type that implements `Into<String>` for the filename.
- [**breaking**] `Recovery::are_we_the_last_man_standing()` has been renamed to `is_last_device()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the PR please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? If we require a link to the PR, at this point we should use towncrier, since this would be equivalently painful in terms of DX (i.e. have to push another time after the first push, to figure out what the final PR number is)

Copy link
Contributor

@poljar poljar Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because people find them useful. No, Towncrier has more issues since you, just like with git-cliff, don't incrementally edit the changelog.


## [0.9.0] - 2024-12-18

Expand Down
2 changes: 1 addition & 1 deletion crates/matrix-sdk/src/encryption/recovery/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ impl Recovery {
/// If the user does not enable recovery before logging out of their last
/// device, they will not be able to decrypt historic messages once they
/// create a new device.
pub async fn are_we_the_last_man_standing(&self) -> Result<bool> {
pub async fn is_last_device(&self) -> Result<bool> {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(crate::Error::NoOlmMachine)?;
let user_id = olm_machine.user_id();
Expand Down
Loading