chore!(encryption): rename are_we_the_last_man_standing to is_last_device
#4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
approved these changes
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4522 +/- ##
==========================================
- Coverage 85.35% 85.34% -0.02%
==========================================
Files 285 285
Lines 31978 31978
==========================================
- Hits 27295 27291 -4
- Misses 4683 4687 +4 ☔ View full report in Codecov by Sentry. |
…_device` While the former name is arguably more fun, the latter is more descriptive of what the function does.
bnjbvr
force-pushed
the
bnjbvr/rename-fun-function-name
branch
from
8a7a922 to
8682d5f
Compare
poljar
reviewed
Jan 13, 2025
| @@ -28,6 +28,7 @@ All notable changes to this project will be documented in this file. | |||
| call `AttachmentConfig::new().thumbnail(thumbnail)` now instead. | |||
| - [**breaking**] `Room::send_attachment()` and `RoomSendQueue::send_attachment()` | |||
| now take any type that implements `Into<String>` for the filename. | |||
| - [**breaking**] `Recovery::are_we_the_last_man_standing()` has been renamed to `is_last_device()`. | |||
There was a problem hiding this comment.
Why? If we require a link to the PR, at this point we should use towncrier, since this would be equivalently painful in terms of DX (i.e. have to push another time after the first push, to figure out what the final PR number is)
There was a problem hiding this comment.
Because people find them useful. No, Towncrier has more issues since you, just like with git-cliff, don't incrementally edit the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the former name is arguably more fun, the latter is more descriptive of what the function does.