Skip to content

feature: send voice message API #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 12, 2023
Merged

feature: send voice message API #2697

merged 15 commits into from
Oct 12, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Oct 11, 2023

This PR adds a ffi binding for sending voice messages in the legacy format (before extensible events). It also makes minor changes in the matrix-sdk crate to accomodate this change.

Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can undo the latest commit now and run cargo update -p ruma-events instead to get a crates.io version that includes the new constructors.

@alfogrillo alfogrillo force-pushed the alfogrillo/send-voice-message branch from 9a1dba4 to 5b1178d Compare October 11, 2023 09:02
@alfogrillo
Copy link
Contributor Author

You can undo the latest commit now and run cargo update -p ruma-events instead to get a crates.io version that includes the new constructors.

Thanks.
Done here.

@alfogrillo alfogrillo marked this pull request as ready for review October 11, 2023 13:52
@alfogrillo alfogrillo requested a review from a team as a code owner October 11, 2023 13:52
@alfogrillo alfogrillo requested review from bnjbvr and removed request for a team October 11, 2023 13:52
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ba2a513) 78.77% compared to head (c4ab772) 78.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   78.77%   78.72%   -0.05%     
==========================================
  Files         200      200              
  Lines       20359    20371      +12     
==========================================
  Hits        16037    16037              
- Misses       4322     4334      +12     
Files Coverage Δ
crates/matrix-sdk/src/attachment.rs 32.85% <0.00%> (-1.48%) ⬇️
crates/matrix-sdk/src/encryption/mod.rs 53.12% <0.00%> (ø)
crates/matrix-sdk/src/media.rs 59.18% <0.00%> (-5.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooo voice messages \o/ Gen Z thanks you for your duty.

@alfogrillo alfogrillo force-pushed the alfogrillo/send-voice-message branch from 598f109 to 370356f Compare October 12, 2023 14:41
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bnjbvr bnjbvr enabled auto-merge (squash) October 12, 2023 16:15
@bnjbvr bnjbvr merged commit f826999 into main Oct 12, 2023
@bnjbvr bnjbvr deleted the alfogrillo/send-voice-message branch October 12, 2023 16:34
julioromano pushed a commit to element-hq/element-x-android that referenced this pull request Oct 13, 2023
…1562)

* Update dependency org.matrix.rustcomponents:sdk-android to v0.1.62
* Add `sendVoiceMessage()` API from matrix-org/matrix-rust-sdk#2697
* Fix other breaking changes

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Romano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants