Skip to content

Update dependency org.matrix.rustcomponents:sdk-android to v0.1.62 #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 13, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.matrix.rustcomponents:sdk-android 0.1.61 -> 0.1.62 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 13, 2023 01:38
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Oct 13, 2023
@renovate renovate bot requested review from ganfra and removed request for a team October 13, 2023 01:38
@ganfra ganfra requested review from julioromano and removed request for ganfra October 13, 2023 05:43
@julioromano julioromano requested review from bmarty and ganfra October 13, 2023 06:55
@julioromano
Copy link

@ganfra @bmarty can you please give it a quick look too? There's a breaking change which switches to ByteArray a few existing API. Nothing to worry about, just informational.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@julioromano julioromano force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from 9acd0fb to be7ee31 Compare October 13, 2023 07:48
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some cleanup to do and you can merge.

@@ -301,7 +301,7 @@ class RustMatrixClient constructor(
@OptIn(ExperimentalUnsignedTypes::class)
override suspend fun uploadAvatar(mimeType: String, data: ByteArray): Result<Unit> =
withContext(sessionDispatcher) {
runCatching { client.uploadAvatar(mimeType, data.toUByteArray().toList()) }
runCatching { client.uploadAvatar(mimeType, data) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the OptIn above and it will be fine.

@@ -385,7 +385,7 @@ class RustMatrixClient constructor(
@OptIn(ExperimentalUnsignedTypes::class)
override suspend fun uploadMedia(mimeType: String, data: ByteArray, progressCallback: ProgressCallback?): Result<String> = withContext(sessionDispatcher) {
runCatching {
client.uploadMedia(mimeType, data.toUByteArray().toList(), progressCallback?.toProgressWatcher())
client.uploadMedia(mimeType, data, progressCallback?.toProgressWatcher())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the OptIn above and it will be fine.

@@ -376,7 +376,7 @@ class RustMatrixRoom(
@OptIn(ExperimentalUnsignedTypes::class)
override suspend fun updateAvatar(mimeType: String, data: ByteArray): Result<Unit> = withContext(roomDispatcher) {
runCatching {
innerRoom.uploadAvatar(mimeType, data.toUByteArray().toList(), null)
innerRoom.uploadAvatar(mimeType, data, null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the OptIn above and it will be fine.

@julioromano julioromano force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from df24cf3 to fd214fd Compare October 13, 2023 07:53
@julioromano julioromano force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from fd214fd to 5cc81ee Compare October 13, 2023 07:54
@julioromano julioromano enabled auto-merge (squash) October 13, 2023 07:55
@julioromano julioromano disabled auto-merge October 13, 2023 08:01
@julioromano julioromano enabled auto-merge (squash) October 13, 2023 08:02
@julioromano
Copy link

julioromano commented Oct 13, 2023

Adds the sendVoiceMessage() API from: matrix-org/matrix-rust-sdk#2697

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/S3r3k2

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julioromano julioromano merged commit 054d0a7 into develop Oct 13, 2023
@julioromano julioromano deleted the renovate/org.matrix.rustcomponents-sdk-android-0.x branch October 13, 2023 08:19
@ganfra
Copy link
Member

ganfra commented Oct 13, 2023

All these changes on uniffi means async uniffi has been updated too, see #1563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants